From: Mark H Weaver <mhw@netris.org>
To: 宋文武 <iyzsong@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/7] gnu: Add djvulibre.
Date: Mon, 02 Mar 2015 00:49:21 -0500 [thread overview]
Message-ID: <87twy40x0e.fsf@netris.org> (raw)
In-Reply-To: <CAHZE2pdBdP6V2Mq8Fj+vXY6Vj3vL=59D6ZTQigvEk6gxbvEt9Q@mail.gmail.com> ("宋文武"'s message of "Mon, 2 Mar 2015 13:27:34 +0800")
宋文武 <iyzsong@gmail.com> writes:
> 2015-03-02 7:47 GMT+08:00 Paul van der Walt <paul@denknerd.org>:
>> * gnu/packages/pdf.scm (djvulibre): New variable.
>> ---
>> gnu/packages/pdf.scm | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
>> index 7b4f2ab..76c77d9 100644
>> --- a/gnu/packages/pdf.scm
>> +++ b/gnu/packages/pdf.scm
>> @@ -2,6 +2,7 @@
>> ;;; Copyright © 2013, 2015 Andreas Enge <andreas@enge.fr>
>> ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
>> ;;; Copyright © 2014, 2015 Ricardo Wurmus <rekado@elephly.net>
>> +;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -143,6 +144,27 @@
>> (license license:gpl3) ; or gpl2, but not gpl2+
>> (home-page "http://www.foolabs.com/xpdf/")))
>>
>> +
>> +
Just one blank line between package definitions.
>> +(define-public djvulibre
>> + (package
>> + (name "djvulibre")
>> + (version "3.5.27")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append "mirror://sourceforge/djvulibre/djvulibre-"
>> + version ".tar.gz"))
>> + (sha256
>> + (base32
>> + "0psh3zl9dj4n4r3lx25390nx34xz0bg0ql48zdskhq354ljni5p6"))))
>> + (build-system gnu-build-system)
>> + (home-page "http://djvu.sourceforge.net/")
>> + (synopsis "DjVuLibre is a GPL implementation of DjVu, a document format.")
> Synposis is too long, and shouldn't contain package name, end with peroid, etc.
> Perhaps just "Implementation of DjVu"?
I would suggest "Implementation of the DjVu document format" for the
sake of those who aren't familiar with DjVu.
Otherwise I agree with 宋文武's suggestions.
Can you send an updated patch?
Thanks!
Mark
next prev parent reply other threads:[~2015-03-02 5:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 23:47 [PATCH 1/7] gnu: Add girara Paul van der Walt
2015-03-01 23:47 ` [PATCH 2/7] gnu: Add djvulibre Paul van der Walt
2015-03-02 5:27 ` 宋文武
2015-03-02 5:49 ` Mark H Weaver [this message]
2015-03-02 9:31 ` Ludovic Courtès
2015-03-01 23:47 ` [PATCH 3/7] gnu: Add zathura Paul van der Walt
2015-03-01 23:47 ` [PATCH 4/7] gnu: Add zathura PDF plugin Paul van der Walt
2015-03-01 23:47 ` [PATCH 5/7] gnu: Add zathura DjVu plugin Paul van der Walt
2015-03-01 23:47 ` [PATCH 6/7] gnu: Add zathura postscript plugin Paul van der Walt
2015-03-01 23:47 ` [PATCH 7/7] gnu: Add zathura comicbook plugin Paul van der Walt
2015-03-02 5:55 ` [PATCH 1/7] gnu: Add girara 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twy40x0e.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.