[PATCH] gnu: sdl: Allow dlopen for OpenGL.

[PATCH] gnu: sdl: Allow dlopen for OpenGL.

[宋文武]

Fixes a regression introduced in 666aa99.
Reported by Felipe López and David Thompso.

* gnu/packages/sdl.scm (sdl)[inputs]: Add glu.
  [arguments]<#:configure-flags>: Replace '--disable-sdl-dlopen' with
  '--disable-alsa-shared --disable-pulseaudio-shared --disable-x11-shared'.
---
 gnu/packages/sdl.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
index 03aa56d..fd555f9 100644
--- a/gnu/packages/sdl.scm
+++ b/gnu/packages/sdl.scm
@@ -60,8 +60,11 @@
     (build-system gnu-build-system)
     (arguments
      '(;; Explicitly link against shared libraries instead of dlopening them.
-       ;; For X11, ALSA, PulseAudio, etc.
-       #:configure-flags '("--disable-sdl-dlopen")
+       ;; For X11, ALSA, and PulseAudio.
+       ;; OpenGL library is still dlopened at runtime.
+       #:configure-flags '("--disable-alsa-shared"
+                           "--disable-pulseaudio-shared"
+                           "--disable-x11-shared")
 
        #:tests? #f)) ; no check target
     (propagated-inputs
@@ -71,6 +74,7 @@
     (native-inputs `(("pkg-config" ,pkg-config)))
     (inputs `(("libxrandr" ,libxrandr)
               ("mesa" ,mesa)
+              ("glu" ,glu)
               ("alsa-lib" ,alsa-lib)
               ("pulseaudio" ,pulseaudio)))
     (synopsis "Cross platform game development library")
-- 
2.2.1

Re: [PATCH] gnu: sdl: Allow dlopen for OpenGL.

[David Thompson]

宋文武 <iyzsong@gmail.com> writes:

> Fixes a regression introduced in 666aa99.
> Reported by Felipe López and David Thompso.

Unfortunately, this doesn't solve the issue.  I need to dig deeper into
the SDL source to figure out exactly why it's still failing.

I use the following crude command to test, run from a git checkout of Sly[0].

    guix environment -l package.scm -E "guile -c \"(use-modules ((sdl sdl) #:prefix sdl:)) (sdl:init 'video) (pk 'window (sdl:set-video-mode 320 240 24 'opengl))\""

(any package that has guile-sdl as an input will do, but there are none
in the distro yet)

When the test fails, the output is:

    ;;; (window #f)

If I remove the 'opengl flag, a window is succesfully opened:

    ;;; (window #<SDL-Surface 320x240 24 bpp>)

We'll find the culprit, eventually! :)

[0] https://gitorious.org/sly/sly

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] gnu: sdl: Allow dlopen for OpenGL.

[Ludovic Courtès]

David Thompson <dthompson2@worcester.edu> skribis:

> I use the following crude command to test, run from a git checkout of Sly[0].
>
>     guix environment -l package.scm -E "guile -c \"(use-modules ((sdl sdl) #:prefix sdl:)) (sdl:init 'video) (pk 'window (sdl:set-video-mode 320 240 24 'opengl))\""

Do you run it on GuixSD or on an FHS distro?  In the latter case, it
might end up loading a shared object from the host distro, which could
fail for a variety of reasons.

Ludo’.

Re: [PATCH] gnu: sdl: Allow dlopen for OpenGL.

[David Thompson]

Ludovic Courtès <ludo@gnu.org> writes:

> David Thompson <dthompson2@worcester.edu> skribis:
>
>> I use the following crude command to test, run from a git checkout of Sly[0].
>>
>>     guix environment -l package.scm -E "guile -c \"(use-modules ((sdl sdl) #:prefix sdl:)) (sdl:init 'video) (pk 'window (sdl:set-video-mode 320 240 24 'opengl))\""
>
> Do you run it on GuixSD or on an FHS distro?  In the latter case, it
> might end up loading a shared object from the host distro, which could
> fail for a variety of reasons.

This is on Debian.  I haven't had the opportunity to try on GuixSD yet.

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] gnu: sdl: Allow dlopen for OpenGL.

[宋文武]

David Thompson <dthompson2@worcester.edu> writes:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> David Thompson <dthompson2@worcester.edu> skribis:
>>
>>> I use the following crude command to test, run from a git checkout of Sly[0].
>>>
>>>     guix environment -l package.scm -E "guile -c \"(use-modules ((sdl sdl) #:prefix sdl:)) (sdl:init 'video) (pk 'window (sdl:set-video-mode 320 240 24 'opengl))\""
>>
>> Do you run it on GuixSD or on an FHS distro?  In the latter case, it
>> might end up loading a shared object from the host distro, which could
>> fail for a variety of reasons.
>
> This is on Debian.  I haven't had the opportunity to try on GuixSD
> yet.
Sorry for the late reply.

I got it work with Sly on GuixSD by set LD_LIBRARY_PATH to
/gnu/store/xxx-mesa/lib. So IMO this should fix the regression.

To avoid loading a GL driver from the host distro, we can
link sdl with mesa explicitly.


Updated patches sent to ML.



>
> -- 
> David Thompson
> Web Developer - Free Software Foundation - http://fsf.org
> GPG Key: 0FF1D807
> Support the FSF: https://fsf.org/donate