all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* New ‘formatting’ checker
@ 2015-08-19  9:42 Ludovic Courtès
  2015-08-19 12:22 ` Andy Wingo
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2015-08-19  9:42 UTC (permalink / raw)
  To: guix-devel

Hi!

‘guix lint’ now has a ‘formatting’ checker, which currently just checks
for tabs, trailing white space, and long lines.  The idea is to remove
the burden of checking those things from reviewers, and to avoid
frustrations caused by reviews that report trailing white space.  :-)

It’s not perfect because it doesn’t know about sexp boundaries, so it
might report about issues in the package that comes next.  It’s OK
though.

Comments welcome!

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ‘formatting’ checker
  2015-08-19  9:42 New ‘formatting’ checker Ludovic Courtès
@ 2015-08-19 12:22 ` Andy Wingo
  2015-08-19 22:27   ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Wingo @ 2015-08-19 12:22 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Wed 19 Aug 2015 11:42, ludo@gnu.org (Ludovic Courtès) writes:

> Hi!
>
> ‘guix lint’ now has a ‘formatting’ checker, which currently just checks
> for tabs, trailing white space, and long lines.  The idea is to remove
> the burden of checking those things from reviewers, and to avoid
> frustrations caused by reviews that report trailing white space.  :-)
>
> It’s not perfect because it doesn’t know about sexp boundaries, so it
> might report about issues in the package that comes next.  It’s OK
> though.
>
> Comments welcome!

How about a git hook that runs guix lint and also checks the formatting
of commit logs?

A

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ‘formatting’ checker
  2015-08-19 12:22 ` Andy Wingo
@ 2015-08-19 22:27   ` Ludovic Courtès
  2015-08-20  9:24     ` Andy Wingo
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2015-08-19 22:27 UTC (permalink / raw)
  To: Andy Wingo; +Cc: guix-devel

Andy Wingo <wingo@igalia.com> skribis:

> How about a git hook that runs guix lint and also checks the formatting
> of commit logs?

Having a hook that runs Guix on Savannah doesn’t really seem doable
unfortunately; however, a review bot may be even better, we’ll see.

I wouldn’t know how to check the formatting of commit logs
automatically.

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: New ‘formatting’ checker
  2015-08-19 22:27   ` Ludovic Courtès
@ 2015-08-20  9:24     ` Andy Wingo
  0 siblings, 0 replies; 4+ messages in thread
From: Andy Wingo @ 2015-08-20  9:24 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Thu 20 Aug 2015 00:27, ludo@gnu.org (Ludovic Courtès) writes:

> Andy Wingo <wingo@igalia.com> skribis:
>
>> How about a git hook that runs guix lint and also checks the formatting
>> of commit logs?
>
> Having a hook that runs Guix on Savannah doesn’t really seem doable
> unfortunately; however, a review bot may be even better, we’ll see.
>
> I wouldn’t know how to check the formatting of commit logs
> automatically.

We can have hooks locally.  Simply being able to tell contributors
"enable this hook, it will reduce your review latency" would be helpful.

A

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-08-20  9:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19  9:42 New ‘formatting’ checker Ludovic Courtès
2015-08-19 12:22 ` Andy Wingo
2015-08-19 22:27   ` Ludovic Courtès
2015-08-20  9:24     ` Andy Wingo

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.