From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH 1/2] gnu: Add eyed3. Date: Mon, 24 Aug 2015 18:48:04 -0400 Message-ID: <87twromhgb.fsf@netris.org> References: <20150817225715.79d7df3d@debian-netbook> <87wpwqs2zx.fsf@gmail.com> <20150820181936.74fa0ed7@debian-netbook> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU0Xg-0004o8-5A for guix-devel@gnu.org; Mon, 24 Aug 2015 18:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZU0Xc-0004yk-RP for guix-devel@gnu.org; Mon, 24 Aug 2015 18:48:40 -0400 Received: from world.peace.net ([50.252.239.5]:55842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZU0Xc-0004yP-N0 for guix-devel@gnu.org; Mon, 24 Aug 2015 18:48:36 -0400 In-Reply-To: <20150820181936.74fa0ed7@debian-netbook> (Efraim Flashner's message of "Thu, 20 Aug 2015 18:19:36 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Efraim Flashner Cc: guix-devel@gnu.org Efraim Flashner writes: > On Thu, 20 Aug 2015 17:50:10 +0800 > =E5=AE=8B=E6=96=87=E6=AD=A6 wrote: > >> Efraim Flashner writes: >>=20 >> > * gnu/packages/mp3.scm (eyed3): New variable. >> > --- >> > gnu/packages/mp3.scm | 25 +++++++++++++++++++++++++ >> > 1 file changed, 25 insertions(+) >> > [...] >> > + (license license:gpl2))) >> The sources have "any later version", so it's 'gpl2+'. > > The website says: "eyeD3 is written and maintained by Travis Shirk and is > licensed under version 2 of the GPL." And that is backed up by the COPYING > file in the mercurial repo: https://bitbucket.org/nicfit/eyed3/src. Upon > checking the actual source files, it does indeed say "(at your option) any > later version", so it looks like I was mislead by not finding that wordin= g in > the COPYING file. I suppose it's not widely known, but what really matters is the copying permission notices in the files themselves. So indeed, this should be gpl2+. >> eyeD3 is both a tool and python library, I wonder whether >> 'python-eyed3' fits better. > > 'python-eyed3' is probably a better name. I wonder perhaps as a python > library it should be in python.scm instead of mp3.scm. Anyone have a > suggestion on that front? If it includes a library, then I think it should be named 'python-eyed3'. This is our usual convention, and it has the advantage that we can add 'python2-eyed3' later, in case someone wants it. Also, your mail client seems to have applied word-wrapping to the patch, so some of the "+" signs have been wrapped into the description. This is what I see: --8<---------------cut here---------------start------------->8--- + (description + "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3 files. +It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard. Additionally it +displays several information about the file such as length and bitrate from an +MP3 file.") --8<---------------cut here---------------end--------------->8--- This makes it difficult for us to apply it, since we'd have to fix it up by hand. Can you persuade your mail client to avoid word-wrapping? You could make it an attachment if needed. Thanks! Mark