From: Mark H Weaver <mhw@netris.org>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: openblas: Fix configure flags on armhf and take target
Date: Thu, 01 Oct 2015 12:59:51 -0400 [thread overview]
Message-ID: <87twqar0c8.fsf@netris.org> (raw)
In-Reply-To: <20151001084613.GA6497@debian> (Andreas Enge's message of "Thu, 1 Oct 2015 10:46:13 +0200")
Andreas Enge <andreas@enge.fr> writes:
> The attached patch fixes the build of openblas (on which 48 packages depend
> according to "guix refresh -l") on armhf.
Excellent!
> From 8802c118fed2c93ee60d90a5cc883c1c3328d531 Mon Sep 17 00:00:00 2001
> From: Andreas Enge <privat@xobs-novena>
> Date: Thu, 1 Oct 2015 10:32:29 +0200
> Subject: [PATCH] gnu: openblas: Fix configure flags on armhf and take target
> system into account for cross building.
>
> * gnu/packages/maths.scm (openblas)[arguments]: Make package substitutable
> and enable runtime cpu detection only on x86 systems. Take the target
> system into account when cross compiling.
> ---
> gnu/packages/maths.scm | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 45fda14..d67f7fa 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -1474,10 +1474,13 @@ constant parts of it.")
> (build-system gnu-build-system)
> (arguments
> `(#:tests? #f ;no "check" target
> - ;; DYNAMIC_ARCH is not supported on MIPS. When it is disabled,
> + ;; DYNAMIC_ARCH is only supported on x86. When it is disabled,
> ;; OpenBLAS will tune itself to the build host, so we need to disable
> ;; substitutions.
> - #:substitutable? ,(not (string-prefix? "mips" (%current-system)))
> + #:substitutable?
> + ,(let ((system (or (%current-target-system) (%current-system))))
> + (or (string-prefix? "x86_64" system)
> + (string-prefix? "i686" system)))
It's not your fault, but the fact that (%current-system) returns a
"system" string (e.g. "mips64el-linux") but (%current-target-system)
returns a GNU triplet (e.g. "mips64el-unknown-linux-gnu") is very
confusing. The fact that we use (or (%current-target-system)
(%current-system)) in many places, and name variables like the one
above "system" reinforces that confusion.
To mitigate this, how about renaming the variable above to
'system-or-triplet'?
Another possible issue is that our Hurd port seems to use "i586" in
several places. I'm not sure if we have to check for that as well.
Maybe we need a helper procedure to check for Intel systems.
* * *
More importantly, it seems a shame for non-Intel users to have to
compile OpenBLAS and ~48 other packages from source code, especially
since it's not practical to compile large packages on many smaller armhf
systems.
Debian provides pre-compiled openblas binaries for armhf, so there must
be a way to disable tuning for the build host, and the answer must be in
the Debian packaging. Any takers?
Anyway, your patch seems like a clear improvement for now, so I'd say go
ahead and push it, possibly with the suggested variable renaming.
Thanks!
Mark
next prev parent reply other threads:[~2015-10-01 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 8:46 [PATCH] gnu: openblas: Fix configure flags on armhf and take target Andreas Enge
2015-10-01 13:25 ` Ludovic Courtès
2015-10-01 17:36 ` Andreas Enge
2015-10-01 16:59 ` Mark H Weaver [this message]
2015-10-01 20:50 ` Ludovic Courtès
2015-10-02 18:01 ` Andreas Enge
2015-10-13 6:20 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twqar0c8.fsf@netris.org \
--to=mhw@netris.org \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.