From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/2] gnu: Add manaplus. Date: Fri, 09 Oct 2015 23:56:36 +0200 Message-ID: <87twpz4sff.fsf@gnu.org> References: <87wpv2jvgr.fsf@gmail.com> <87oag8qkp8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zkfee-0002R8-3k for guix-devel@gnu.org; Fri, 09 Oct 2015 17:56:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZkfeZ-0000ou-Kp for guix-devel@gnu.org; Fri, 09 Oct 2015 17:56:44 -0400 In-Reply-To: (David Thompson's message of "Fri, 9 Oct 2015 12:56:28 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel , Alex Kost "Thompson, David" skribis: > On Fri, Oct 9, 2015 at 8:40 AM, Ludovic Court=C3=A8s wrote: >> Alex Kost skribis: >> >>> I don't know if there is a better workaround for the SDL headers, but >>> this problem is rather common: there is a workaround in 'abbaye' and a >>> special patch for 'pingus'. >>> >>> The problem is: the source code has lines like this: >>> >>> #include >>> >>> but the headers of all SDL packages are placed in =E2=80=9Cinclude/SDL/= =E2=80=9D >>> subdirectories. And an upstream often doesn't use "pkg-config" for >>> every SDL package to define CFLAGS and assumes that all SDL headers are >>> placed in one directory. So we have to invent workarounds for such >>> packages. >>> >>> I just mention this problem here, perhaps someone will come up with a >>> general solution. >> >> Can=E2=80=99t =E2=80=98sdl-union=E2=80=99 be used here? I think it was = created specifically to >> solve this problem. (Currently it=E2=80=99s private to (gnu packages sd= l) but >> you can export it.) > > Do you have any concerns about this package being picked up by UIs now > that it will be public? Might confuse a user or two, dunno. No opinion. If you think we=E2=80=99d rather keep it hidden, we can wrap i= t in a thunk for instance so that the UIs don=E2=80=99t pick it up. WDYT? Ludo=E2=80=99.