From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christopher Allan Webber <cwebber@dustycloud.org>
Subject: Re: [PATCH 1/7] guix: git: Support shallow git clones if a tag is
	available
Date: Tue, 20 Oct 2015 10:20:09 -0500
Message-ID: <87twplin1u.fsf@dustycloud.org>
References: <1439893929.575691.5108@rusty> <876143o49y.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1ZoYiS-0005zY-J2
	for guix-devel@gnu.org; Tue, 20 Oct 2015 11:20:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1ZoYiQ-0003Nk-PU
	for guix-devel@gnu.org; Tue, 20 Oct 2015 11:20:44 -0400
In-reply-to: <876143o49y.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s writes:

> Andy Wingo <wingo@igalia.com> skribis:
>
>> * guix/build/git.scm (git-fetch): Instead of cloning the remote repo, =
use the
>>   lower-level "init" / "fetch" / "checkout" operations.  This lets us =
make a
>>   shallow checkout if we are checking out a tag.
>>
>> * guix/git-download.scm (<git-reference>): Add tag field.
>>   (git-fetch): Support git references with tags but no commits.
>
> This sounds like a nice improvement.  Please move the =E2=80=9CThis let=
s us=E2=80=9D
> sentence to a comment, and drop the newline between entries.

This does look like a nice improvement!  It seems like it kind of got
dropped on the floor.  Is there still interest?

>> --- a/guix/build/git.scm
>> +++ b/guix/build/git.scm
>
> Make sure to add a copyright line in there.
>
> [...]
>
>>    git-reference make-git-reference
>>    git-reference?
>>    (url        git-reference-url)
>> -  (commit     git-reference-commit)
>> +  (commit     git-reference-commit (default #f))
>> +  (tag        git-reference-tag (default #f))
>
> So far we=E2=80=99ve been using =E2=80=98commit=E2=80=99 to denote comm=
its or tags.  I guess a
> bunch of packages will need to be updated.
>
> There=E2=80=99s the issue that one could erroneously specify both =E2=80=
=98commit=E2=80=99 and
> =E2=80=98tag=E2=80=99, and then one of them would be ignored.
>
> What about doing something like:
>
>   1. renaming =E2=80=98commit=E2=80=99 to =E2=80=98spec=E2=80=99;
>   2. adding a =E2=80=98type=E2=80=99 field which would default to 'comm=
it and could be
>      changed to 'tag
>
> ?
>
>> +                   ;; FIXME: Pass #:tag when fixed daemons are widely
>> +                   ;; deployed.
>> +                   ;; #:tag '#$(git-reference-tag ref)
>
> The daemon is not involved here, AFAICS, so you can uncomment the line.
>
> Thanks,
> Ludo=E2=80=99.