From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 3/6] emacs: Find packages in system profiles. Date: Thu, 14 Jan 2016 11:38:38 +0300 Message-ID: <87twmgtv1t.fsf@gmail.com> References: <1452419630-4399-1-git-send-email-alezost@gmail.com> <1452419630-4399-4-git-send-email-alezost@gmail.com> <878u3ubkzc.fsf@gnu.org> <87pox59pjj.fsf@gmail.com> <87y4btyud0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJdQX-0001Jh-Ic for guix-devel@gnu.org; Thu, 14 Jan 2016 03:38:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJdQU-0007n6-AK for guix-devel@gnu.org; Thu, 14 Jan 2016 03:38:41 -0500 In-Reply-To: <87y4btyud0.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 13 Jan 2016 23:42:19 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-01-14 01:42 +0300) wrote: > Alex Kost skribis: > >> Ludovic Court=C3=A8s (2016-01-12 23:28 +0300) wrote: > > [...] > >>> I had overlooked it, but wouldn=E2=80=99t it be easier if patch #2 did: >>> >>> +(defvar guix-system-profile >>> + (concat guix-config-state-directory "/profiles/system/profile") >>> + "System profile.") >>> >>> ? >> Not really. >> >> Both "/var/guix/profiles/system" (which I called =E2=80=9Csystem profile= =E2=80=9D) and >> "/var/guix/profiles/system/profile" (which I called =E2=80=9Cpackages pr= ofile=E2=80=9D) >> are needed. The former =E2=80=94 for finding generations, and the latte= r =E2=80=94 for >> finding packages. >> >> I actually need "/var/guix/profiles/system" in the first place, so if >> =E2=80=98guix-system-profile=E2=80=99 is not an appropriate name for thi= s variable, it >> should be renamed (what name do you suggest?). > > Indeed, it=E2=80=99s confusing. I don=E2=80=99t have a better name to su= ggest, though. BTW I've just noticed that '%system-profile' from (guix scripts system) has the same value, so "/var/guix/profiles/system" can be called a =E2=80=9Csystem profile=E2=80=9D after all I think ;-) >> And about name confusion: now I see that =E2=80=9Cprofile=E2=80=9D shoul= d be used only >> for a directory (symlink) with packages. But I always thought that a >> directory that has generations can also be named a =E2=80=9Cprofile=E2= =80=9D (apparently >> cannot), especially taking into account =E2=80=98profile-generations=E2= =80=99 procedure >> from (guix profiles) module: >> >> (profile-generations "/var/guix/profiles/system") >> >> That's why ^^^ I called "/var/guix/profiles/system" a system profile. > > Initially, I would have said that as long as FOO/manifest exists, FOO > can be called a profile. That=E2=80=99s the definition of a =E2=80=9Cpro= file=E2=80=9D in the > sense of (guix profiles). > > Like a profile, /var/guix/profiles/system has generations, but unlike > =E2=80=9Creal profiles=E2=80=9D, it is not created by =E2=80=98profile-de= rivation=E2=80=99. > > The solution in this patch looks good, after all! Great, thanks! --=20 Alex