From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/6] emacs: Find packages in system profiles.
Date: Thu, 14 Jan 2016 11:38:38 +0300 [thread overview]
Message-ID: <87twmgtv1t.fsf@gmail.com> (raw)
In-Reply-To: <87y4btyud0.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 13 Jan 2016 23:42:19 +0100")
Ludovic Courtès (2016-01-14 01:42 +0300) wrote:
> Alex Kost <alezost@gmail.com> skribis:
>
>> Ludovic Courtès (2016-01-12 23:28 +0300) wrote:
>
> [...]
>
>>> I had overlooked it, but wouldn’t it be easier if patch #2 did:
>>>
>>> +(defvar guix-system-profile
>>> + (concat guix-config-state-directory "/profiles/system/profile")
>>> + "System profile.")
>>>
>>> ?
>> Not really.
>>
>> Both "/var/guix/profiles/system" (which I called “system profile”) and
>> "/var/guix/profiles/system/profile" (which I called “packages profile”)
>> are needed. The former — for finding generations, and the latter — for
>> finding packages.
>>
>> I actually need "/var/guix/profiles/system" in the first place, so if
>> ‘guix-system-profile’ is not an appropriate name for this variable, it
>> should be renamed (what name do you suggest?).
>
> Indeed, it’s confusing. I don’t have a better name to suggest, though.
BTW I've just noticed that '%system-profile' from (guix scripts system)
has the same value, so "/var/guix/profiles/system" can be called a
“system profile” after all I think ;-)
>> And about name confusion: now I see that “profile” should be used only
>> for a directory (symlink) with packages. But I always thought that a
>> directory that has generations can also be named a “profile” (apparently
>> cannot), especially taking into account ‘profile-generations’ procedure
>> from (guix profiles) module:
>>
>> (profile-generations "/var/guix/profiles/system")
>>
>> That's why ^^^ I called "/var/guix/profiles/system" a system profile.
>
> Initially, I would have said that as long as FOO/manifest exists, FOO
> can be called a profile. That’s the definition of a “profile” in the
> sense of (guix profiles).
>
> Like a profile, /var/guix/profiles/system has generations, but unlike
> “real profiles”, it is not created by ‘profile-derivation’.
>
> The solution in this patch looks good, after all!
Great, thanks!
--
Alex
next prev parent reply other threads:[~2016-01-14 8:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 9:53 [PATCH 0/6] emacs: Add "M-x guix-system-generations" Alex Kost
2016-01-10 9:53 ` [PATCH 1/6] guix system: Export <boot-parameters> accessors Alex Kost
2016-01-12 20:25 ` Ludovic Courtès
2016-01-13 20:44 ` Alex Kost
2016-01-13 22:33 ` Ludovic Courtès
2016-01-14 8:34 ` Alex Kost
2016-01-14 13:25 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 2/6] emacs: profiles: Add 'guix-system-profile' Alex Kost
2016-01-12 20:25 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 3/6] emacs: Find packages in system profiles Alex Kost
2016-01-12 20:28 ` Ludovic Courtès
2016-01-13 20:45 ` Alex Kost
2016-01-13 22:42 ` Ludovic Courtès
2016-01-14 8:38 ` Alex Kost [this message]
2016-01-14 13:27 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 4/6] emacs: Replace 'generation-diff' search with 'profile-diff' Alex Kost
2016-01-12 20:29 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 5/6] emacs: Remove 'generation' search type Alex Kost
2016-01-12 20:31 ` Ludovic Courtès
2016-01-10 9:53 ` [PATCH 6/6] emacs: Add interface for system generations Alex Kost
2016-01-12 20:35 ` Ludovic Courtès
2016-01-13 20:56 ` Alex Kost
2016-01-13 22:44 ` Ludovic Courtès
2016-01-12 20:23 ` [PATCH 0/6] emacs: Add "M-x guix-system-generations" Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twmgtv1t.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.