all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Lirzin <mthl@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnu: bind-utils: Build and install “nsupdate”.
Date: Thu, 21 Jan 2016 14:14:01 +0100	[thread overview]
Message-ID: <87twm7krc6.fsf@gnu.org> (raw)
In-Reply-To: <idjvb6n9pct.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Thu, 21 Jan 2016 11:52:18 +0100")

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> Okay.  Attached are three new patches.  I thought I should better split
> this up into separate commits for clarity.

Splitting thoses changes is a good idea.  Thanks for taking the time to
do it.

>From b276ca4c3940663137e4449144b2256f03e47d27 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 Jan 2016 11:20:30 +0100
> Subject: [PATCH 1/3] gnu: bind-utils: Use "modify-phases" syntax.
>
> * gnu/packages/dns.scm (bind-utils): Use "modify-phases" syntax.

OK.

>From 4c7f432edbd65abad749170a280d88181f533635 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 Jan 2016 11:41:10 +0100
> Subject: [PATCH 2/3] gnu: bind-utils: Generalize "build" and "install" phases.
>
> * gnu/packages/dns.scm (bind-utils)[arguments]: Generalize "build" and
>   "install" phases.

OK.

>From 6bd7b2a30ef1f128097c2ff4030e465e3955a34f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 21 Jan 2016 11:42:17 +0100
> Subject: [PATCH 3/3] gnu: bind-utils: Build and install "nsupdate".
>
> * gnu/packages/dns.scm (bind-utils)[arguments]: Also build and install
>   "nsupdate" executable.

I think “Also” can be removed here.  Otherwise LGTM.

Thanks,

--
Mathieu Lirzin

  reply	other threads:[~2016-01-21 13:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 15:11 [PATCH] gnu: bind-utils: Build and install “nsupdate” Ricardo Wurmus
2016-01-14  0:46 ` Mathieu Lirzin
2016-01-14  8:59   ` Alex Kost
2016-01-14 11:53     ` Ricardo Wurmus
2016-01-14 23:46       ` Mathieu Lirzin
2016-01-21 10:52         ` Ricardo Wurmus
2016-01-21 13:14           ` Mathieu Lirzin [this message]
2016-01-21 14:58             ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twm7krc6.fsf@gnu.org \
    --to=mthl@gnu.org \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.