From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/5] gnu: Add avr-binutils.
Date: Tue, 19 Apr 2016 16:55:51 +0200
Message-ID: <87twix3ax4.fsf@gnu.org>
References: <1460639824-9976-1-git-send-email-dthompson2@worcester.edu>
	<1460639824-9976-2-git-send-email-dthompson2@worcester.edu>
	<87wpo0ktpz.fsf@gnu.org> <570FE252.6040400@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55866)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1asX4J-0001Dx-M6
	for guix-devel@gnu.org; Tue, 19 Apr 2016 10:56:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1asX4I-0004ZP-MI
	for guix-devel@gnu.org; Tue, 19 Apr 2016 10:55:59 -0400
In-Reply-To: <570FE252.6040400@gmail.com> (Manolis Ragkousis's message of
	"Thu, 14 Apr 2016 21:32:50 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel@gnu.org

Manolis Ragkousis <manolis837@gmail.com> skribis:

> On 04/14/16 20:04, Ludovic Court=C3=A8s wrote:
>
>> AFAICS --target=3Davr is redundant:
>>=20
>> --8<---------------cut here---------------start------------->8---
>> $ git describe
>> v0.10.0-204-ga2d0e20
>> $ wget -q -O - $(./pre-inst-env guix build --log-file -e '((@ (gnu packa=
ges cross-base) cross-binutils) "avr")') |grep -e --target
>> configure flags: ("CONFIG_SHELL=3D/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110=
744j2-bash-4.3.42/bin/bash" "SHELL=3D/gnu/store/b1yqjimbdh5bf9jnizd4h7yf110=
744j2-bash-4.3.42/bin/bash" "--prefix=3D/gnu/store/gqmq8gis9igpg4xy6022mvq8=
qpvp7kk4-binutils-cross-avr-2.25.1" "--enable-fast-install" "--build=3Dx86_=
64-unknown-linux-gnu" "--target=3Davr" "--with-sysroot=3D/" "LDFLAGS=3D-sta=
tic-libgcc" "--with-lib-path=3D/no-ld-lib-path" "--disable-werror" "--enabl=
e-install-libbfd" "--enable-deterministic-archives")
>> --8<---------------cut here---------------end--------------->8---
>>=20
>> =E2=80=A6 and --disable-nls is orthogonal and probably unnecessary.
>>=20
>> Can we skip this patch?  :-)
>
> We added --disable-nls mostly because it was suggested from the avr-libc
> manual to be passed to binutils and gcc.
> <http://www.nongnu.org/avr-libc/user-manual/install_tools.html>
>
> David can you build the toolchain without it and see if it works?

It surely does.  :-)

> And I would really prefer if we had a way to explicitly install
> avr-binutils.  This way it will be more clear to someone only wanting to
> install this specific package.
>
> We could keep something like this
>
> (define-public avr-binutils
>   (package
>     (inherit (cross-binutils "avr"))
>     (name "avr-binutils")))

I see.  In that case, that=E2=80=99s a fine thing to do!

Maybe (define-public avr-binutils (cross-binutils "avr")) is enough
though?  Or is its name too wordy?

Thanks,
Ludo=E2=80=99.