[Patch] ruby-spring

[Patch] ruby-spring

[Matthew Jordan]

[-- Attachment #1: Type: text/plain, Size: 51 bytes --]


This is dependent on ruby-debug-inspector patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to add ruby-spring. --]
[-- Type: text/x-patch, Size: 1326 bytes --]

From a7cf3f9f00e29af7a07fead35689da9f47dd98cb Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:29:24 -0400
Subject: [PATCH 2/4] gnu: Add ruby-spring.

* gnu/packages/rails.scm: Modified file.
---
 gnu/packages/rails.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
index 8241c18..7a65850 100644
--- a/gnu/packages/rails.scm
+++ b/gnu/packages/rails.scm
@@ -28,6 +28,27 @@
   #:use-module (gnu packages gcc)
   #:use-module (guix build-system ruby))
 
+(define-public ruby-spring
+  (package
+    (name "ruby-spring")
+    (version "1.7.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "spring" version))
+       (sha256
+        (base32
+         "165f6n6am36md1lzaivcg9bx09f7iph4vab0f8av2rlza4yi791p"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:tests? #f))
+    (synopsis
+     "Preloads your application so things like console, rake and tests run faster")
+    (description
+     "Preloads your application so things like console, rake and tests run faster")
+    (home-page "https://github.com/rails/spring")
+    (license expat)))
+
 (define-public ruby-debug-inspector
   (package
     (name "ruby-debug-inspector")
-- 
2.8.3


[-- Attachment #3: Type: text/plain, Size: 37 bytes --]


--
Matthew Jordan
Sent with my mu4e

Re: [Patch] ruby-spring

[Ben Woodcroft]

On 01/06/16 01:36, Matthew Jordan wrote:
> This is dependent on ruby-debug-inspector patch.
I'm more supportive of this being in a new rails.scm file than 
ruby-debug-inspector. I made some changes to your patch. Here's the 
diff, WDYT?

I think it could still do with an improved synopsis and description at 
least. Would you like to do this and submit a properly formatted patch 
please?

Thanks.

+
+(define-public ruby-spring
+  (package
+    (name "ruby-spring")
+    (version "1.7.1")
+    (source
+     (origin
+       (method url-fetch)
+       ;; Fetch from github as the gem does not contain testing code.
+       (uri (string-append
+             "https://github.com/rails/spring/archive/v"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0czc4mkwfngcqmna49a0l98f6wlhdq2i8gwr63lrmk90d9k25x1n"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:test-target "test:unit"
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'remove-bump
+           (lambda _
+             (substitute* "spring.gemspec"
+               (("gem.add_development_dependency 'bump'") ""))
+             (substitute* "Rakefile"
+               (("require \\\"bump/tasks\\\"") ""))
+             #t)))))
+    (native-inputs
+     `(("bundler" ,bundler)
+       ("ruby-activesupport" ,ruby-activesupport)))
+    (synopsis
+     "Preloads your application so things like console, rake and tests 
run faster")
+    (description
+     "Preloads your application so things like console, rake and tests 
run faster")
+    (home-page "https://github.com/rails/spring")
+    (license license:expat)))

Re: [Patch] ruby-spring

[Matthew Jordan]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

Good Day,

I have updated the synopsis and the description.  Please see the
following comment also;

> +    (arguments
> +     `(#:test-target "test:unit"
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'remove-bump
> +           (lambda _
> +             (substitute* "spring.gemspec"
> +               (("gem.add_development_dependency 'bump'") ""))
> +             (substitute* "Rakefile"
> +               (("require \\\"bump/tasks\\\"") ""))
> +             #t)))))

The files spring.gemspec and Rakefile do not exist.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to add ruby-spring. --]
[-- Type: text/x-patch, Size: 1437 bytes --]

From 3a9d916463e7d10c275b65b5712ccd288fffdc07 Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:29:24 -0400
Subject: [PATCH] gnu: Add ruby-spring.

* gnu/packages/rails.scm: Modified file.
---
 gnu/packages/rails.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
index 77ab354..1b1de06 100644
--- a/gnu/packages/rails.scm
+++ b/gnu/packages/rails.scm
@@ -23,6 +23,29 @@
   #:use-module (gnu packages ruby)
   #:use-module (guix build-system ruby))
 
+(define-public ruby-spring
+  (package
+    (name "ruby-spring")
+    (version "1.7.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "spring" version))
+       (sha256
+        (base32
+         "165f6n6am36md1lzaivcg9bx09f7iph4vab0f8av2rlza4yi791p"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:tests? #f)) ;; no Rakefile found
+    (synopsis
+     "Spring is a Rails application preloader")
+    (description
+     "Spring is a Rails application preloader.  It speeds up development by
+keeping your application running in the background so you don't need to boot
+it every time you run a test, rake task or migration.")
+    (home-page "https://github.com/rails/spring")
+    (license expat)))
+
 (define-public ruby-debug-inspector
   (package
     (name "ruby-debug-inspector")
-- 
2.8.3


[-- Attachment #3: Type: text/plain, Size: 53 bytes --]


Respectuflly,

-- 
Matthew Jordan
Sent with my mu4e

Re: [Patch] ruby-spring

[Ben Woodcroft]

On 02/06/16 05:05, Matthew Jordan wrote:
> Good Day,

It is cloudy and cold outside here and the air conditioning is being its 
usual overzealous self. But at least we won the football. I hope it is a 
good day for you too.

> I have updated the synopsis and the description.  Please see the
> following comment also;
>
>> +    (arguments
>> +     `(#:test-target "test:unit"
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'check 'remove-bump
>> +           (lambda _
>> +             (substitute* "spring.gemspec"
>> +               (("gem.add_development_dependency 'bump'") ""))
>> +             (substitute* "Rakefile"
>> +               (("require \\\"bump/tasks\\\"") ""))
>> +             #t)))))
> The files spring.gemspec and Rakefile do not exist.

Not in the gem they don't, but I changed the source field to download 
the release from GitHub. Unfortunately not including test files in the 
gem is not uncommon for Ruby libraries (especially rails ones), but we 
should endeavour to include them where possible.

> +(define-public ruby-spring
> +  (package
> +    (name "ruby-spring")
> +    (version "1.7.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (rubygems-uri "spring" version))
> +       (sha256
> +        (base32
> +         "165f6n6am36md1lzaivcg9bx09f7iph4vab0f8av2rlza4yi791p"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;; no Rakefile found

We should add tests as I suggested in the last email, so this doesn't 
matter now, but for future reference comments at the end of lines like 
this by convention are only prefixed by a single ';' not ';;' as you 
have done here.

> +    (synopsis
> +     "Spring is a Rails application preloader")

I think it looks better if the synopsis is kept on one line, if possible.

> +    (description
> +     "Spring is a Rails application preloader.  It speeds up development by
> +keeping your application running in the background so you don't need to boot
> +it every time you run a test, rake task or migration.")

s/your/the rails/, otherwise looks good.

> +    (home-page"https://github.com/rails/spring")
> +    (license expat)))
Shall we keep the same license: prefix in rails.scm as ruby.scm? Then 
here it would be "license:expat" with appropriate changes to the top of 
the file.

Thanks,
ben

Re: [Patch] ruby-spring

[Matthew Jordan]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

Good Day,

I have updated the patch as suggested.  Note that prefix for the
license module import has been added in "[Patch] ruby-debug-inspector"
as that patch is the first in the rails patch series.

Also my apologies with regards to the your previous email, I missed the
change to the fetch url.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add ruby-spring package. --]
[-- Type: text/x-patch, Size: 2057 bytes --]

From 77154d38b096ba75cc9bc8910ff158445d76f87c Mon Sep 17 00:00:00 2001
From: Matthew Jordan <matthewjordandevops@yandex.com>
Date: Tue, 31 May 2016 07:29:24 -0400
Subject: [PATCH 2/2] gnu: Add ruby-spring.

* gnu/packages/rails.scm (ruby-spring): New variable
---
 gnu/packages/rails.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/rails.scm b/gnu/packages/rails.scm
index 80e73d7..48a7008 100644
--- a/gnu/packages/rails.scm
+++ b/gnu/packages/rails.scm
@@ -23,6 +23,44 @@
   #:use-module (gnu packages ruby)
   #:use-module (guix build-system ruby))
 
+(define-public ruby-spring
+  (package
+    (name "ruby-spring")
+    (version "1.7.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        (string-append "https://github.com/rails/spring/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0czc4mkwfngcqmna49a0l98f6wlhdq2i8gwr63lrmk90d9k25x1n"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:test-target "test:unit"
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'remove-bump
+           (lambda _
+             (substitute* "spring.gemspec"
+               (("gem.add_development_dependency 'bump'") ""))
+             (substitute* "Rakefile"
+               (("require \\\"bump/tasks\\\"") ""))
+             #t)))))
+    (native-inputs
+     `(("bundler" ,bundler)
+       ("ruby-activesupport" ,ruby-activesupport)))
+    (synopsis
+     "Spring is a Rails application preloader")
+    (description
+     "Spring is a Rails application preloader.  It speeds up development by
+keeping your application running in the background so you don't need to boot
+it every time you run a test, rake task or migration.")
+    (home-page "https://github.com/rails/spring")
+    (license license:expat)))
+
 (define-public ruby-debug-inspector
   (package
     (name "ruby-debug-inspector")
-- 
2.8.3


[-- Attachment #3: Type: text/plain, Size: 50 bytes --]


Sincerely,

-- 
Matthew Jordan
Sent with my mu4e

Re: [Patch] ruby-spring

[Ben Woodcroft]

On 06/03/2016 03:39 PM, Matthew Jordan wrote:
> Also my apologies with regards to the your previous email, I missed the
> change to the fetch url.

No problem. I pushed with an added '.' in the commit message.
Thanks,
ben