From: Lukas Gradl <lgradl@openmailbox.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add googletest
Date: Wed, 01 Jun 2016 09:57:53 -0500 [thread overview]
Message-ID: <87twhdez33.fsf@openmailbox.org> (raw)
In-Reply-To: <20160531214400.GA22303@jasmine> (Leo Famulari's message of "Tue, 31 May 2016 17:44:00 -0400")
Thank you for your review!
Leo Famulari <leo@famulari.name> writes:
> On Tue, May 31, 2016 at 08:53:17AM -0500, Lukas Gradl wrote:
>> * gnu/packages/check.scm (googletest): New variable.
>
> Awesome, thanks for this patch!
>
>> + (build-system cmake-build-system)
>
> I noticed in the README.md that upstream suggests use of GNU Make unless
> building from a Git checkout. Did you try that?
I have not tried that. Their README.md left me under the impression
that tests are not supported useing GNU Make, but I just looked at their
Makefile and there are test targets, so I can try using the
gnu-build-system, if that is preferred?
>
>> + (native-inputs
>> + `(("python-2" ,python-2)))
>
> The README also suggests that this is only necessary for building from
> Git, although it's worth finding out what they mean by "re-generating
> certain source files from templates". We prefer to re-build "generated"
> source files since they are not really "source files" in many cases.
>
It seems they generate c++ header files using pump.py. I will look into
that more. Python is also needed for tests.
>> + (replace 'install
>> + (lambda _
>> + (let ((out (assoc-ref %outputs "out")))
>> + (and
>> + (mkdir-p (string-append out "/lib"))
>> + (mkdir-p (string-append out "/include"))
>> + (zero?
>> + (system* "cp" "-r"
>> + "../googletest-release-1.7.0/include"
>> + out))
>> + (zero? (system* "cp" "libgtest.a" "libgtest_main.a"
>> + (string-append out "/lib"))))))))))
>
> I think these uses of (system*) could be replaced by (copy-recursively)
> and (install-file), respectively.
These indeed sound very useful. I will send an updated patch shortly.
Thank you!
Best,
Lukas
next prev parent reply other threads:[~2016-06-01 14:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 20:44 [PATCH] Add googletest Lukas Gradl
2016-05-31 13:53 ` Lukas Gradl
2016-05-31 21:44 ` Leo Famulari
2016-06-01 4:48 ` Efraim Flashner
2016-06-02 13:51 ` Lukas Gradl
2016-06-01 7:47 ` Ludovic Courtès
2016-06-01 14:57 ` Lukas Gradl [this message]
2016-06-02 1:49 ` Leo Famulari
2016-06-02 15:44 ` Lukas Gradl
2016-06-05 13:12 ` Efraim Flashner
2016-06-05 21:09 ` Lukas Gradl
2016-06-09 18:40 ` Efraim Flashner
2016-06-09 22:17 ` Lukas Gradl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twhdez33.fsf@openmailbox.org \
--to=lgradl@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.