From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: torsocks 2.0 bug Date: Mon, 01 Aug 2016 15:37:07 +0000 Message-ID: <87twf4pkkc.fsf@we.make.ritual.n0.is> References: <92c4a901a98ba83b4d21aa69921a942e@riseup.net> <20160129132809.1fe0c52e@debian-netbook> <8b802d8294362c03c133c28a7fb7e3c4@riseup.net> <878u32xhb7.fsf@gnu.org> <20160203193356.GA22324@debian> <87k2h9brtq.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUFHH-0001s7-Cs for guix-devel@gnu.org; Mon, 01 Aug 2016 11:37:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUFHF-0001Es-4h for guix-devel@gnu.org; Mon, 01 Aug 2016 11:37:14 -0400 Received: from mithlond.libertad.in-berlin.de ([2001:67c:1400:2490::1]:37881 helo=beleriand.n0.is) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUFHE-0001Eb-Mh for guix-devel@gnu.org; Mon, 01 Aug 2016 11:37:13 -0400 Received: by beleriand.n0.is (OpenSMTPD) with ESMTPSA id 357163a0 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO for ; Mon, 1 Aug 2016 15:37:11 +0000 (UTC) In-Reply-To: <87k2h9brtq.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel A short note to link threads: It is likely that 2.2.x release will fix the current bug, see https://lists.gnu.org/archive/html/guix-devel/2016-07/msg01452.html ng0@we.make.ritual.n0.is writes: > Hi, > > I found this thread while I was deleting old threads. > > I worked on torsocks-2.1.0 without knowing there was > a discussion before. As expected I ran into problems > too. > > The only change I did so far was version bumping, which > when building torsocks-2.1.0 only fails tests. > > This is because our torsocks-2.0 disable dns patch no > longer works but so far I have found no solution to > fix it. > > Problems appear to be exclusive to tests/unit/test_dns.c , > line 59. > I suggest that whoever wrote the torsocks patch creates > one for torsocks-2.1.0 > > Andreas Enge writes: > >> On Wed, Feb 03, 2016 at 07:08:32PM +0100, swedebugia@riseup.net wrote: >>> '(#:phases (modify-phases %standard-phases >>> + ; FIXME. this phase is still needed but fails. I dont >>> + ; understand why. It works fine when done manually in an >>> + ; environment. >>> (add-before 'configure 'bootstrap >>> (lambda _ >>> - (system* "autoreconf" "-vfi")))))) >>> + (system* "autoreconf" "-i") >> >> The problem is here. First of all, there was no need to drop the options "v" >> and "f". But the real problem comes from dropping the parentheses. >> So now what follows is part of the "lambda" function: >> >>> + ; FIXME. test_fd_passing fail. >>> + #:tests? #f))))) >> >> And it ends with "#f", so the return value of the function is false, and the >> phase fails. >> >> I tried closing more parentheses, and then the build passes, but the tests >> still fail. This would need to be investigated more. >> >> Andreas >> >> -- ♥Ⓐ ng0 Current Keys: https://we.make.ritual.n0.is/ng0.txt For non-prism friendly talk find me on http://www.psyced.org