From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include
	directory.
Date: Wed, 17 Aug 2016 05:57:09 -0400
Message-ID: <87twejwwei.fsf@netris.org>
References: <20160816183938.22794-1-david@craven.ch>
	<20160816183938.22794-15-david@craven.ch> <8737m3ycb9.fsf@netris.org>
	<CAL1_imngJa=wyCOoLEPEtzd9bJjTFzhgzRadAo8n+fZB8-W8=Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59793)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bZxc6-0004P4-N9
	for guix-devel@gnu.org; Wed, 17 Aug 2016 05:58:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bZxc1-0007dM-JQ
	for guix-devel@gnu.org; Wed, 17 Aug 2016 05:58:21 -0400
Received: from world.peace.net ([50.252.239.5]:54236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bZxc1-0007dI-G1
	for guix-devel@gnu.org; Wed, 17 Aug 2016 05:58:17 -0400
In-Reply-To: <CAL1_imngJa=wyCOoLEPEtzd9bJjTFzhgzRadAo8n+fZB8-W8=Q@mail.gmail.com>
	(David Craven's message of "Wed, 17 Aug 2016 11:35:41 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>

David Craven <david@craven.ch> writes:

>> What is the reason for this change?  Would it be appropriate to submit a
>> bug report upstream to add this to their "make install"?
>
> The reason is because applications may contain #include <gst/gstconfig.h>,
> but gstconfig.h was moved to the lib directory because it contains "platform
> specific information".
>
> What do you suggest?

The pkgconfig file for gstreamer, $out/lib/pkgconfig/pkgconfig-1.0.pc,
includes this:

  Cflags: -I${includedir} -I${libdir}/gstreamer-1.0/include

Where ${libdir} is ${prefix}/lib.  So, the include path needed to find
<gst/gstconfig.h> should automatically be included by non-broken build
systems.

What application(s) are you aware of that are unable to find
<gst/gstconfig.h>?

In general, we should stick to upstream packaging unless it is clearly
broken or there is a compelling reason to deviate.  In this case, if an
application can't find <gst/gstconfig.h>, then it would seem to have a
buggy build system, and we should fix the problem there.

What do you think?

    Thanks,
      Mark