From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/4] gnu: Add python-avro.
Date: Tue, 04 Oct 2016 11:32:44 +0200 [thread overview]
Message-ID: <87twcsbgsj.fsf@gnu.org> (raw)
In-Reply-To: <20160925211728.7636-1-mbakke@fastmail.com> (Marius Bakke's message of "Sun, 25 Sep 2016 22:17:25 +0100")
Hi!
Marius Bakke <mbakke@fastmail.com> skribis:
> * gnu/packages/serialization.scm (avro-version): New variable (private).
> (avro-source): New variable (private).
> (python-avro, python2-avro): New variables.
[...]
> +;;; Avro uses a single source repository for all implementations. The individual
> +;;; released versions often have missing or incomplete test data, so we define
> +;;; the common source here for use in all avro packages.
Two semicolons please. :-)
> +(define-public python2-avro
> + (let ((base (package-with-python2 (strip-python2-variant python-avro))))
> + (package (inherit base)
> + (arguments
> + `(#:tests? #f ; Requires Apache Ivy.
> + #:python ,python-2 ; Needed when overriding inherited args.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'enter-source
> + (lambda _ (chdir "lang/py") #t))))))))
Rather:
(package
(inherit base)
(arguments
(substitute-keyword-arguments (package-arguments python-avro)
((#:phases _)
`(modify-phases %standard-phases
(add-after 'unpack 'enter-source …))))))
OK with this change, thanks!
Ludo’.
prev parent reply other threads:[~2016-10-04 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 21:17 [PATCH 1/4] gnu: Add python-avro Marius Bakke
2016-09-25 21:17 ` [PATCH 2/4] gnu: Add python-sphinx-bootstrap-theme Marius Bakke
2016-09-26 9:35 ` Hartmut Goebel
2016-09-25 21:17 ` [PATCH 3/4] gnu: Add python-sphinx-argparse Marius Bakke
2016-09-26 9:36 ` Hartmut Goebel
2016-09-25 21:17 ` [PATCH 4/4] gnu: Add python2-pbcommand Marius Bakke
2016-09-26 9:38 ` Hartmut Goebel
2016-09-26 9:31 ` [PATCH 1/4] gnu: Add python-avro Hartmut Goebel
2016-09-26 19:56 ` Marius Bakke
2016-10-04 9:35 ` Ludovic Courtès
2016-10-04 9:32 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twcsbgsj.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.