From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add vim-full. Date: Mon, 17 Oct 2016 23:10:52 +0100 Message-ID: <87twca7hjn.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> References: <20161015203841.19904-2-ng0@we.make.ritual.n0.is> <20161017163240.15227-1-ng0@we.make.ritual.n0.is> <20161017163240.15227-2-ng0@we.make.ritual.n0.is> <878ttm970g.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> <87bmyi65w7.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwG7Y-0003En-Sr for guix-devel@gnu.org; Mon, 17 Oct 2016 18:11:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwG7U-0007HY-1r for guix-devel@gnu.org; Mon, 17 Oct 2016 18:11:00 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35045) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwG7T-0007G0-TZ for guix-devel@gnu.org; Mon, 17 Oct 2016 18:10:55 -0400 In-Reply-To: <87bmyi65w7.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 , guix-devel@gnu.org ng0 writes: > Hi, > > thanks for reviewing. > > Marius Bakke writes: > >> ng0 writes: >> >>> * gnu/packages/vim.scm (vim-full): New variable. >>> * gnu/packages/patches/vim-8.0.0003.patch: New file. >>> * gnu/packages/patches/vim-8.0.0004.patch: New file. >>> * gnu/packages/patches/vim-8.0.0005.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add patches. >>> --- >>> gnu/local.mk | 3 ++ >>> gnu/packages/patches/vim-8.0.0003.patch | 87 +++++++++++++++++++++++++++++++++ >>> gnu/packages/patches/vim-8.0.0004.patch | 60 +++++++++++++++++++++++ >>> gnu/packages/patches/vim-8.0.0005.patch | 45 +++++++++++++++++ >>> gnu/packages/vim.scm | 81 ++++++++++++++++++++++++++++++ >>> 5 files changed, 276 insertions(+) >>> create mode 100644 gnu/packages/patches/vim-8.0.0003.patch >>> create mode 100644 gnu/packages/patches/vim-8.0.0004.patch >>> create mode 100644 gnu/packages/patches/vim-8.0.0005.patch >> >> [...] >> >>> + >>> +(define-public vim-full >>> + (package >>> + (inherit vim) >>> + (name "vim-full") >>> + (version (package-version vim)) >>> + (source >>> + (origin >>> + (method url-fetch) >>> + (uri (string-append "ftp://ftp.vim.org/pub/vim/unix/vim-" >>> + version ".tar.bz2")) >>> + (sha256 >>> + (base32 >>> + "1s34rf8089klsbdx5l0iw7vjymir0kzfrx8wb30s31wygnq29axc")) >>> + ;; Patches need to be applied sequentially. 8.0 is the release of >>> + ;; vim version 8.0.0002 so we start at 8.0.0003 >>> + (patches (search-patches "vim-8.0.0003.patch" >>> + "vim-8.0.0004.patch" >>> + "vim-8.0.0005.patch")))) >> >> Shouldn't these patches be applied on the base vim package? Then >> "vim-full" can just inherit the source from there. I also think >> "version" should be adjusted to match the patch level. > > No (for explanation see the other emails I've sent in the earlier > thread). > I agree on the version, I will update that. Upstream recommends using the Github releases [0] for 8.0 which are at 8.0.0042 already. Do you think it makes sense to switch to that source for both packages? Then we might avoid carrying the patches entirely. 0: https://github.com/vim/vim/releases