From mboxrd@z Thu Jan  1 00:00:00 1970
From: ng0 <ng0@we.make.ritual.n0.is>
Subject: Re: [PATCH] gnu: Add irctest.
Date: Wed, 19 Oct 2016 20:48:59 +0000
Message-ID: <87twc83w04.fsf@we.make.ritual.n0.is>
References: <20161018134224.24053-1-ng0@we.make.ritual.n0.is>
	<20161018134224.24053-2-ng0@we.make.ritual.n0.is>
	<20161019201837.GA8287@jasmine>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ng0@we.make.ritual.n0.is>) id 1bwxna-0001lb-7U
	for guix-devel@gnu.org; Wed, 19 Oct 2016 16:49:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ng0@we.make.ritual.n0.is>) id 1bwxnV-0006P8-Bj
	for guix-devel@gnu.org; Wed, 19 Oct 2016 16:49:18 -0400
Received: from aibo.runbox.com ([91.220.196.211]:51107)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ng0@we.make.ritual.n0.is>)
	id 1bwxnV-0006OX-54
	for guix-devel@gnu.org; Wed, 19 Oct 2016 16:49:13 -0400
In-Reply-To: <20161019201837.GA8287@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Hi,

thanks for reviewing

Leo Famulari <leo@famulari.name> writes:

> On Tue, Oct 18, 2016 at 01:42:24PM +0000, ng0 wrote:
>> * gnu/packages/irc.scm (irctest): New variable.
>
> Cool!
>
>> +      (version (string-append "0.1-" revision "." (string-take commit 7)))
>
> 0.1 should be 0.0.0.

No, the setup.py has version: 0.1

>> +      (inputs
>> +       `(("python-ecdsa" ,python-ecdsa)
>> +         ("python-psutil" ,python-psutil)
>> +         ("limnoria" ,limnoria)))
>
> The output does not refer to limnoria:
>
> $ guix gc --references $(./pre-inst-env guix build irctest)
> /gnu/store/pn0lc8cl2c7ja8vgkxs2ka8w9vras8i5-python-ecdsa-0.13
> /gnu/store/qvmmdi87vypfz90n76ph5knca188wrv8-python-psutil-4.3.0
> /gnu/store/z4r53nxw185s5an6kkvs7cgdkwrl1p8l-irctest-0.1-1.548ddb5
>
> Is it just used for building? If so, it should be a native-input.
> Otherwise irctest will stop working after garbage collection.

I think this has to be propagated, I'm not really sure. I need to look
at this when I can focus again