all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ng0 <ng0@we.make.ritual.n0.is>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add irctest.
Date: Wed, 19 Oct 2016 20:48:59 +0000	[thread overview]
Message-ID: <87twc83w04.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <20161019201837.GA8287@jasmine>

Hi,

thanks for reviewing

Leo Famulari <leo@famulari.name> writes:

> On Tue, Oct 18, 2016 at 01:42:24PM +0000, ng0 wrote:
>> * gnu/packages/irc.scm (irctest): New variable.
>
> Cool!
>
>> +      (version (string-append "0.1-" revision "." (string-take commit 7)))
>
> 0.1 should be 0.0.0.

No, the setup.py has version: 0.1

>> +      (inputs
>> +       `(("python-ecdsa" ,python-ecdsa)
>> +         ("python-psutil" ,python-psutil)
>> +         ("limnoria" ,limnoria)))
>
> The output does not refer to limnoria:
>
> $ guix gc --references $(./pre-inst-env guix build irctest)
> /gnu/store/pn0lc8cl2c7ja8vgkxs2ka8w9vras8i5-python-ecdsa-0.13
> /gnu/store/qvmmdi87vypfz90n76ph5knca188wrv8-python-psutil-4.3.0
> /gnu/store/z4r53nxw185s5an6kkvs7cgdkwrl1p8l-irctest-0.1-1.548ddb5
>
> Is it just used for building? If so, it should be a native-input.
> Otherwise irctest will stop working after garbage collection.

I think this has to be propagated, I'm not really sure. I need to look
at this when I can focus again

      reply	other threads:[~2016-10-19 20:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 13:42 [PATCH] Add: irctest ng0
2016-10-18 13:42 ` [PATCH] gnu: Add irctest ng0
2016-10-19 20:18   ` Leo Famulari
2016-10-19 20:48     ` ng0 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twc83w04.fsf@we.make.ritual.n0.is \
    --to=ng0@we.make.ritual.n0.is \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.