From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH]  gnu: Add libjxr.
Date: Thu, 03 Nov 2016 14:36:01 +0100
Message-ID: <87twbovg72.fsf@gnu.org>
References: <87eg39qvjh.fsf@openmailbox.org> <20161021235859.GA9570@jasmine>
	<87a8dwrdf5.fsf@openmailbox.org> <20161023212929.GB6318@jasmine>
	<87bmy4bni6.fsf@gnu.org> <87mvhn4va2.fsf@openmailbox.org>
	<87a8dmvpge.fsf@gnu.org> <87ins94zwf.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50371)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c2IBb-0007CQ-Ft
	for guix-devel@gnu.org; Thu, 03 Nov 2016 09:36:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c2IBY-0005GK-0w
	for guix-devel@gnu.org; Thu, 03 Nov 2016 09:36:07 -0400
In-Reply-To: <87ins94zwf.fsf@openmailbox.org> (Kei Kebreau's message of "Sun,
	30 Oct 2016 11:31:12 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org

Kei Kebreau <kei@openmailbox.org> skribis:

> From 316a4f7a676bf6b8cc7a8f8795b74fa0ebab3e36 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Sun, 30 Oct 2016 11:05:30 -0400
> Subject: [PATCH] gnu: Add libjxr.
>
> * gnu/packages/images.scm (libjxr): New variable.
> * gnu/packages/patches/libjxr-fix-function-signature.patch: New file.
> * gnu/packages/patches/libjxr-fix-typos.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register patches.

[...]

> +(define-public libjxr
> +  (package
> +    (name "libjxr")
> +    (version "1.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://debian/pool/main/j/jxrlib/jx=
rlib_"
> +                                  version ".orig.tar.gz"))

Please add a comment saying why we=E2=80=99re using the Debian-provided sou=
rce.

> +                   (replace 'install
> +                     (lambda* (#:key outputs #:allow-other-keys)

=E2=80=A6 and a comment saying why we roll our own =E2=80=98install=E2=80=
=99 phase.

OK with these changes, thanks!

Ludo=E2=80=99.