From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-2?Q?Tom=E1=B9_=C8ech?= Subject: Re: [PATCH 2/3] services: Add wpa-supplicant-service. Date: Sat, 12 Nov 2016 19:16:55 +0100 Message-ID: <87twbcd0mg.wl-sleep_walker@gnu.org> References: <20161109212245.23531-1-sleep_walker@gnu.org> <20161109212245.23531-2-sleep_walker@gnu.org> <87eg2k473f.fsf@gnu.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5crO-0005wT-2J for guix-devel@gnu.org; Sat, 12 Nov 2016 13:17:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5crK-00059S-Sl for guix-devel@gnu.org; Sat, 12 Nov 2016 13:17:02 -0500 In-Reply-To: <87eg2k473f.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org I thought I sent reply already but I probably did not thanks to connection problems ;-) On Wed, 09 Nov 2016 23:32:52 +0100, Ludovic Court=C3=A8s wrote: >=20 > Tom=C3=A1=C5=A1 =C4=8Cech skribis: >=20 > > * gnu/services/networking.scm (wpa-supplicant-service): New procedure. > > (wpa-supplicant-service-type): New variable. > > (wpa-supplicant-shepherd-service): New procedure. > > * doc/guix.texi (Networking Services): Document it. >=20 > Could you remove the =E2=80=98wpa-supplicant-service=E2=80=99 procedure a= nd simply > expose and document =E2=80=98wpa-supplicant-service-type=E2=80=99? So us= ers would > write: >=20 > (service wpa-supplicant-service-type wpa-supplicant) >=20 > instead of: >=20 > (wpa-supplicant-service) >=20 > I=E2=80=99m trying to incrementally get us to do that for all services, b= ecause > I think it=E2=80=99s a bit clearer (one immediately sees what type of > configuration value is used.) I can't say whether it is clearer or not from language or design perspective, but after the change I had to have a look on your mail to see how it is done properly so it is less user friendly. Nevertheless done. >=20 > > +@cindex WPA Supplicant > > +@deffn {Scheme Procedure} wpa-supplicant-service @ > > + [#:wpa-supplicant @var{wpa-supplicant}] > > +Return a service that runs @url{https://w1.fi/wpa_supplicant/,WPA > > +supplicant}, an authentication daemon required to authenticate against > > +encrypted WiFi or ethernet networks. >=20 > Could you also mention that wpa_supplicant is started to listen on a > D-Bus interface? Done. > > + (requirement '(user-processes dbus-system loopback)) > > + (start #~(make-forkexec-constructor > > + (list (string-append #$wpa-supplicant > > + "/sbin/wpa_supplicant") > > + "-u" "-B"))) >=20 > I think it would be more reliable to use > =E2=80=9C-P/var/run/wpa_supplicant.pid=E2=80=9D, and thus >=20 > #:pid-file "/var/run/wpa_supplicant.pid" >=20 > OK with changes along these lines, thanks! Good idea! > OK! > So does Connman work as expected now? I guess it was all broken before? It works better with WiFi after this change but it is still far from perfec= t. 1] it still can be controlled only by root (it requires D-Bus policy to be installed properly and I need to figure out where and how) 2] connman-vpnd is not started - I'll probably make another service for that 3] there needs to be created some configuration mechanism for features like enabling/disabling dns proxy (which is IMHO killer feature of connman) or ignoring network devices 4] connman is harder to configure without other clients so I'm working on connman-json-client (curses) and connman-ui (GTK3) Best regards, S_W