From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 1/8] gnu: Add aspell-dict-he.
Date: Tue, 22 Nov 2016 23:01:51 +0300
Message-ID: <87twazi8r4.fsf@gmail.com>
References: <20161121210035.13726-1-efraim@flashner.co.il>
	<20161121210035.13726-2-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43481)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1c9HGP-0002R9-LV
	for guix-devel@gnu.org; Tue, 22 Nov 2016 15:01:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1c9HGK-0004eM-0D
	for guix-devel@gnu.org; Tue, 22 Nov 2016 15:01:57 -0500
Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:34646)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <alezost@gmail.com>) id 1c9HGJ-0004dg-Pv
	for guix-devel@gnu.org; Tue, 22 Nov 2016 15:01:51 -0500
Received: by mail-wm0-x241.google.com with SMTP id g23so6311972wme.1
	for <guix-devel@gnu.org>; Tue, 22 Nov 2016 12:01:51 -0800 (PST)
In-Reply-To: <20161121210035.13726-2-efraim@flashner.co.il> (Efraim Flashner's
	message of "Mon, 21 Nov 2016 23:00:28 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner (2016-11-21 23:00 +0200) wrote:

> * gnu/packages/aspell.scm (aspell-dict-he): New variable.
> ---
>  gnu/packages/aspell.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
> index b702412..21014c0 100644
> --- a/gnu/packages/aspell.scm
> +++ b/gnu/packages/aspell.scm
> @@ -2,6 +2,7 @@
>  ;;; Copyright =C2=A9 2013, 2014, 2015 Ludovic Court=C3=A8s <ludo@gnu.org>
>  ;;; Copyright =C2=A9 2015, 2016 Alex Kost <alezost@gmail.com>
>  ;;; Copyright =C2=A92016 John Darrington <jmd@gnu.org>
> +;;; Copyright =C2=A92016 Efraim Flashner <efraim@flashner.co.il>
                  ^
I would add a space here (and on the line for John as well).

Otherwise I think this patch is OK to push.

>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -155,3 +156,10 @@ dictionaries, including personal ones.")
>                       #:sha256
>                       (base32
>                        "0ffb87yjsh211hllpc4b9khqqrblial4pzi1h9r3v465z1yhn=
3j4")))
> +
> +(define-public aspell-dict-he
> +  (aspell-dictionary "he" "Hebrew"
> +                     #:version "1.0-0"
> +                     #:sha256
> +                     (base32
> +                      "13bhbghx5b8g0119g3wxd4n8mlf707y41vlf59irxjj0kynan=
kfn")))

--=20
Alex