From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] Generate manpages for the udisks utility Date: Sun, 27 Nov 2016 11:15:45 +0100 Message-ID: <87twatfctq.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <87inr9tupu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAwUz-0000Gb-82 for guix-devel@gnu.org; Sun, 27 Nov 2016 05:15:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAwUu-0007yr-A8 for guix-devel@gnu.org; Sun, 27 Nov 2016 05:15:53 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40001) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAwUu-0007yh-4a for guix-devel@gnu.org; Sun, 27 Nov 2016 05:15:48 -0500 In-Reply-To: <87inr9tupu.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Maxim Cournoyer , guix-devel@gnu.org --=-=-= Content-Type: text/plain Maxim Cournoyer writes: > Hi Guix, > > This patch adds the manpages to the udisks package. It appears that the > manpages were previously disabled because of the strict docbook catalog > files location verification in the configure script. The fix is > essentially equivalent to what was done in commit > b4787e71aca75392f394a127a7df537a0a016b04 to fix the build of gtk-doc, > but is a bit less invasive since it only requires to define the > XML_CATALOG_FILES variable and to pass it to make, rather than to > substitute the catalog string directly in the configure script (FWIU of > the referenced commit). > > There are still some "no ID for constraint linkend" errors output by > xsltproc; unfortunately I have no idea how those can be solved. My > understanding is that these errors mean that xsltproc couldn't find the > reference ID of a linked resource. Here's what those errors look like > in the build log: > > make -j3 XML_CATALOG_FILES="/gnu/store/sp361wnn64zkp3aici69xxmblrf2pfkb-docbook-xsl-1.78.1/xml/xsl/docbook-xsl-1.78.1/catalog.xml /gnu/store/d5lvr5xh8361dwhaqw3y880x9jzlqk4l-docbook-xml-4.3/xml/dtd/docbook/catalog.xml" > Making all in man > make[1]: Entering directory '/home/maxim/devel/udisks-2.1.7/doc/man' > /gnu/store/sjmyrkcm7byz14s87sanf2p14dxbdad8-profile/bin/xsltproc -path "./.." -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl udisksctl.xml > /gnu/store/sjmyrkcm7byz14s87sanf2p14dxbdad8-profile/bin/xsltproc -path "./.." -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl udisksd.xml > /gnu/store/sjmyrkcm7byz14s87sanf2p14dxbdad8-profile/bin/xsltproc -path "./.." -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl udisks.xml > Error: no ID for constraint linkend: udisksd.8. > Error: no ID for constraint linkend: udisks-polkit-actions. > Error: no ID for constraint linkend: udisksd.8. > Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Drive.Id. > Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintSystem. > Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintIgnore. > Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintAuto. > Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Drive.CanPowerOff. > Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintName. > Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintIconName. > Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintIconName. > Error: no ID for constraint linkend: gdbus-method-org-freedesktop-UDisks2-Filesystem.Mount. > Error: no ID for constraint linkend: udisksctl.1. > Error: no ID for constraint linkend: udisksd.8. > Error: no ID for constraint linkend: udisks.8. > Error: no ID for constraint linkend: udisksctl.1. > Error: no ID for constraint linkend: umount.udisks2.8. > Note: Writing udisksd.8 > Error: no ID for constraint linkend: udisksd.8. > Error: no ID for constraint linkend: udisksctl.1. > Error: no ID for constraint linkend: umount.udisks2.8. > Error: no ID for constraint linkend: udisks.8. > Error: no ID for constraint linkend: udisks.8. > Error: no ID for constraint linkend: udisksd.8. > Error: no ID for constraint linkend: umount.udisks2.8. > Note: Writing udisks.8 > Note: Writing udisksctl.1 > /gnu/store/sjmyrkcm7byz14s87sanf2p14dxbdad8-profile/bin/xsltproc -path "./.." -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl umount.udisks2.xml > Error: no ID for constraint linkend: udisks.8. > Error: no ID for constraint linkend: udisksd.8. > Error: no ID for constraint linkend: udisksctl.1. > Error: no ID for constraint linkend: umount.8. > Note: Writing umount.udisks2.8 > make[1]: Leaving directory '/home/maxim/devel/udisks-2.1.7/doc/man' > make[1]: Entering directory '/home/maxim/devel/udisks-2.1.7/doc' > make[1]: Nothing to be done for 'all-am'. > make[1]: Leaving directory '/home/maxim/devel/udisks-2.1.7/doc' > > With that said, the manpages otherwise appear to be correctly generated. Thanks! I ran the indentation through emacs and updated the commit message to match our convention based on the GNU coding standards: https://www.gnu.org/prep/standards/standards.html#Change-Logs Pushed as e6cb837489a9bf399c6ca9e2d674355a13e755b1. It would be nice to find out what causes the xsltproc errors, but they don't seem to affect the manpage generation. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlg6slEACgkQoqBt8qM6 VPpOxggAqwyZaH6AwFNnB0hJGst5m68oDmpGmxZ8BxupviUNSk0Yn8HE3jA8yupc SEoTjdUplCxRhm8cPQGIBMOqIeuKvZzXUiC63C6Fed5UzuKCF8i/ZQiRI7pNpoAr sc/JayiC5zZcUU4QdT9bjewL7PbvgUnYg2M+ReX6UugXzQRg3i2rf5Vs3wOcRgM7 wkiU8wY1z0NApg2111mnk3z2AH6LZVqiBKi59EA6+arAK8wmOjIPlsQOlMT054sp U0SD/UZRA5IPZCtge68zeZkR3a0nM4xEnm5ldYA6ZtEMJxwW/LCvcdPaBG6RsKcZ 9RKKH6UY+YaqC7UiSL6pTAh9sMqhVw== =j+Md -----END PGP SIGNATURE----- --=-=-=--