From: Marius Bakke <mbakke@fastmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>, guix-devel@gnu.org
Subject: Re: [PATCH] Generate manpages for the udisks utility
Date: Sun, 27 Nov 2016 11:15:45 +0100 [thread overview]
Message-ID: <87twatfctq.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87inr9tupu.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4597 bytes --]
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hi Guix,
>
> This patch adds the manpages to the udisks package. It appears that the
> manpages were previously disabled because of the strict docbook catalog
> files location verification in the configure script. The fix is
> essentially equivalent to what was done in commit
> b4787e71aca75392f394a127a7df537a0a016b04 to fix the build of gtk-doc,
> but is a bit less invasive since it only requires to define the
> XML_CATALOG_FILES variable and to pass it to make, rather than to
> substitute the catalog string directly in the configure script (FWIU of
> the referenced commit).
>
> There are still some "no ID for constraint linkend" errors output by
> xsltproc; unfortunately I have no idea how those can be solved. My
> understanding is that these errors mean that xsltproc couldn't find the
> reference ID of a linked resource. Here's what those errors look like
> in the build log:
>
> make -j3 XML_CATALOG_FILES="/gnu/store/sp361wnn64zkp3aici69xxmblrf2pfkb-docbook-xsl-1.78.1/xml/xsl/docbook-xsl-1.78.1/catalog.xml /gnu/store/d5lvr5xh8361dwhaqw3y880x9jzlqk4l-docbook-xml-4.3/xml/dtd/docbook/catalog.xml"
> Making all in man
> make[1]: Entering directory '/home/maxim/devel/udisks-2.1.7/doc/man'
> /gnu/store/sjmyrkcm7byz14s87sanf2p14dxbdad8-profile/bin/xsltproc -path "./.." -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl udisksctl.xml
> /gnu/store/sjmyrkcm7byz14s87sanf2p14dxbdad8-profile/bin/xsltproc -path "./.." -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl udisksd.xml
> /gnu/store/sjmyrkcm7byz14s87sanf2p14dxbdad8-profile/bin/xsltproc -path "./.." -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl udisks.xml
> Error: no ID for constraint linkend: udisksd.8.
> Error: no ID for constraint linkend: udisks-polkit-actions.
> Error: no ID for constraint linkend: udisksd.8.
> Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Drive.Id.
> Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintSystem.
> Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintIgnore.
> Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintAuto.
> Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Drive.CanPowerOff.
> Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintName.
> Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintIconName.
> Error: no ID for constraint linkend: gdbus-property-org-freedesktop-UDisks2-Block.HintIconName.
> Error: no ID for constraint linkend: gdbus-method-org-freedesktop-UDisks2-Filesystem.Mount.
> Error: no ID for constraint linkend: udisksctl.1.
> Error: no ID for constraint linkend: udisksd.8.
> Error: no ID for constraint linkend: udisks.8.
> Error: no ID for constraint linkend: udisksctl.1.
> Error: no ID for constraint linkend: umount.udisks2.8.
> Note: Writing udisksd.8
> Error: no ID for constraint linkend: udisksd.8.
> Error: no ID for constraint linkend: udisksctl.1.
> Error: no ID for constraint linkend: umount.udisks2.8.
> Error: no ID for constraint linkend: udisks.8.
> Error: no ID for constraint linkend: udisks.8.
> Error: no ID for constraint linkend: udisksd.8.
> Error: no ID for constraint linkend: umount.udisks2.8.
> Note: Writing udisks.8
> Note: Writing udisksctl.1
> /gnu/store/sjmyrkcm7byz14s87sanf2p14dxbdad8-profile/bin/xsltproc -path "./.." -nonet http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl umount.udisks2.xml
> Error: no ID for constraint linkend: udisks.8.
> Error: no ID for constraint linkend: udisksd.8.
> Error: no ID for constraint linkend: udisksctl.1.
> Error: no ID for constraint linkend: umount.8.
> Note: Writing umount.udisks2.8
> make[1]: Leaving directory '/home/maxim/devel/udisks-2.1.7/doc/man'
> make[1]: Entering directory '/home/maxim/devel/udisks-2.1.7/doc'
> make[1]: Nothing to be done for 'all-am'.
> make[1]: Leaving directory '/home/maxim/devel/udisks-2.1.7/doc'
>
> With that said, the manpages otherwise appear to be correctly generated.
Thanks! I ran the indentation through emacs and updated the commit
message to match our convention based on the GNU coding standards:
https://www.gnu.org/prep/standards/standards.html#Change-Logs
Pushed as e6cb837489a9bf399c6ca9e2d674355a13e755b1.
It would be nice to find out what causes the xsltproc errors, but they
don't seem to affect the manpage generation.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2016-11-27 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-27 4:25 [PATCH] Generate manpages for the udisks utility Maxim Cournoyer
2016-11-27 10:15 ` Marius Bakke [this message]
2016-11-27 23:14 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twatfctq.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.