From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add python-hdf4. Date: Thu, 22 Dec 2016 18:09:07 +0100 Message-ID: <87tw9vao24.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161222.112321.737083559510333929.thomas.danckaert@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cK6rj-0001be-Jd for guix-devel@gnu.org; Thu, 22 Dec 2016 12:09:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cK6re-0000yn-My for guix-devel@gnu.org; Thu, 22 Dec 2016 12:09:15 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39879) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cK6re-0000yO-Bn for guix-devel@gnu.org; Thu, 22 Dec 2016 12:09:10 -0500 In-Reply-To: <20161222.112321.737083559510333929.thomas.danckaert@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Thomas Danckaert , guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thomas Danckaert writes: > Hi Guix, > > this patch adds python-hdf4. I'm not sure if the line =E2=80=9CPython-HD= F4=20 > is a fork of pyhdf.=E2=80=9D in the description is necessary. The origin= al=20 > and =E2=80=9Cofficial=E2=80=9D pyhdf (http://hdfeos.org/software/pyhdf.ph= p) is=20 > somewhat outdated (e.g. doesn't support python3). The "official" pyhdf and this fork was released around the same time and have the same version number. Confusing! But I'll take your word that this one is better. I'd keep the fork comment in the description though, in case someone is looking for pyhdf. Could you wrap pyhdf in '@url{}'? Regarding the patch, I wonder if it should go in (gnu packages maths), similar to how we put PDF libraries in pdf.scm and XML in xml.scm etc. But no strong opinion here. 'python-numpy' should be a propagated-input since it is imported at runtime, and not a dynamically linked C library like the other inputs. The 'check' phase seems to run the build again, and prints at the end "Ran 0 tests in 0.000s". Looking at the Github ".travis.yml", the CI tool runs the command "nosetests" instead of 'python setup.py test' like python-build-system does by default. Can you try replacing the 'check' phase with that command? You'll need 'python-nose' as a native-input. It seems you also forgot to add a copyright line. Can you send an updated patch? Thank you! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhcCLMACgkQoqBt8qM6 VPrIVAf/aAzpFgHq6k17HUbM9SIrVQBizStQBgClykhCvNn4brUlE+yzN13M2T1t +AAgIV0/bKlr4zTG+eazDWK1CoASJsUL9651p28Xp5UXpx4iBIErKJeRWxykFnXk we1Dkn1sp6cQpQK37nk3jw7i2vmn37pCEhT4At3ZUeiCrxlFj91nBq1Zl+Wuh9AV n5Q4AziYyNz6cWogyZfMW5teuFyw22N1syEzz42Uy/IpfS1rz2D1viiVJqX45nNL qZVWThh+8H0D3MM64rmvJBxwTxIvsrbPT1K6fwz41ca5+zoqFavWPi0t+pCdrx8X GDuIXUYmtrPPmHjUC0uhVn/N5/TKlw== =NTNS -----END PGP SIGNATURE----- --=-=-=--