all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Theodoros Foradis <theodoros.for@openmailbox.org>
To: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 1/3] gnu: Add xdot.
Date: Sun, 01 Jan 2017 20:44:16 +0200	[thread overview]
Message-ID: <87tw9i4p6g.fsf@openmailbox.org> (raw)
In-Reply-To: <87k2b9chew.fsf@gnu.org>


Ludovic Courtès writes:

> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> Theodoros Foradis <theodoros.for@openmailbox.org> writes:
>>
>>> * gnu/packages/graphviz.scm (xdot): New variable.
>
> [...]
>
>> Other than the comment above, LGTM. Is there someone more experienced
>> with Python packages who can double check this?
>
> If it builds and passes ‘guix lint’ and looks good to you, please push,
> Kei.
>
> We can always modify it later if we find a problem.
>
> Thanks!
>
> Ludo’.

Hello,

I see that the patch series has not been pushed yet. Do I need to post an
updated patch, including the extra configure flag that was suggested?

Regards,
-- 
Theodoros Foradis

  reply	other threads:[~2017-01-01 18:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-26 14:27 [PATCH 0/3] Add xdot and update yosys Theodoros Foradis
2016-11-26 14:27 ` [PATCH 1/3] gnu: Add xdot Theodoros Foradis
2016-11-27 21:55   ` Kei Kebreau
2016-12-09 14:21     ` Ludovic Courtès
2017-01-01 18:44       ` Theodoros Foradis [this message]
2017-01-02  1:09         ` Leo Famulari
2016-11-26 14:27 ` [PATCH 2/3] gnu: yosys: Add xdot functionality Theodoros Foradis
2016-11-29  0:25   ` Danny Milosavljevic
2016-11-26 14:27 ` [PATCH 3/3] gnu: yosys: Update to 0.7 Theodoros Foradis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw9i4p6g.fsf@openmailbox.org \
    --to=theodoros.for@openmailbox.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.