Re: Bad signature on commit 6a34f4ccc8a5d (gnu: python-prompt-toolkit: Update to 1.0.9.)

[ludo@gnu.org (Ludovic Courtès)]

Hello Guix!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> On 29/12/16 03:10, Leo Famulari wrote:
>> gpg: BAD signature from "Tobias Geerinckx-Rice <me@tobias.gr>"
>
> Oh dear.
>
>> Does anyone else get the same result? Any ideas?
>
> I do, so it's a real® corrupted signature.

It’s a valid signature (gpg parses it correctly):

--8<---------------cut here---------------start------------->8---
$ git cat-file -p 6a34f4ccc8a5d4a48e25ad3c9c512f8634928b91
tree 1fcfe231ee1ee856980ee3e2f055a0d4615c59a6
parent 791ac6a68d1e4bc80f4760cd968cb6c26dbab9ba
author Tobias Geerinckx-Rice <me@tobias.gr> 1482962509 +0100
committer Tobias Geerinckx-Rice <me@tobias.gr> 1482975501 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEcBAABCgAGBQJYZGkNAAoJEJHM25tIVBuZ+3QH/3wYO1BqGBolMzwD5wI5EVGO
 PBfHnvVBGonNUbuI9F7NwJqYbOeS2Nzd19/h/1T6oMclFCzPfPL5MpPQFnihvSo0
 sPdI+KRtXz4jOJ0WLy+JA65zbKpu84PM0rf0+m8iDA8bRCXIQt1Ym2uYdyIcqUj5
 +sCf6wbnrBhCGTf6t7phWCM3wd166V8L8sIHFhnpxfZRVV2sOGXyunHkcWu8v4/6
 Mf2oaBA08Gq+uCffsbHyqMRr03XhnXprAtaM1eKP0/d7G1nj14lM97mEjr9huGDk
 GKA8F+u3W/7FvaVIN9PhCzSrxzgmdMnVm9q61YB4RmEcBD1E/lG5h8dVOY3eMuI=
 =/4F2
 -----END PGP SIGNATURE-----

gnu: python-prompt-toolkit: Update to 1.0.9.

* gnu/packages/python.scm (python-prompt-toolkit): Update to 1.0.9.
--8<---------------cut here---------------end--------------->8---

However, it’s a signature against a different piece of data.

It would be good to figure out how that happened.

The pre-push hook that Leo sent runs ‘git verify-commit’, so it should
catch this kind of problem.

I’m all for adding it to the repo and recommending it in HACKING.

Leo?

But we really need to fix the server-side hook.

Thanks,
Ludo’.