From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add perl-parallel-forkmanager. Date: Thu, 12 Jan 2017 21:27:24 +0100 Message-ID: <87tw9458ib.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRly8-00046j-IW for guix-devel@gnu.org; Thu, 12 Jan 2017 15:27:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRly3-0000Sf-P5 for guix-devel@gnu.org; Thu, 12 Jan 2017 15:27:32 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47568) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cRly3-0000SQ-HI for guix-devel@gnu.org; Thu, 12 Jan 2017 15:27:27 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ra , guix-devel --=-=-= Content-Type: text/plain Ra writes: > * gnu/packages/perl.scm (perl-parallel-forkmanager): New variable. Thanks! This looks mostly good, see comments below. Can you send an updated patch that also includes copyright information? Thanks in advance! > --- > gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm > index 8f103ec..532e360 100644 > --- a/gnu/packages/perl.scm > +++ b/gnu/packages/perl.scm > @@ -7770,3 +7770,29 @@ interface to File::Find::Object.") > (description "Test::TrailingSpace tests for trailing spaces > in Perl source files.") > (license x11))) > + > +(define-public perl-parallel-forkmanager There is a pledge at the top of perl.scm asking to add packages in alphabetic order. Can you adjust the location of this expression accordingly? > + (package > + (name "perl-parallel-forkmanager") > + (version "1.19") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "mirror://cpan/authors/id/Y/YA/YANICK/Parallel-ForkManager-" > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "0wm4wp6p3ah5z212jl12728z68nmxmfr0f03z1jpvdzffnc2xppi")))) > + (build-system perl-build-system) > + (native-inputs > + `(("perl-test-warn" ,perl-test-warn))) > + (home-page > + "http://search.cpan.org/dist/Parallel-ForkManager") > + (synopsis > + "A simple parallel processing fork manager") Synopsis should not start with an article. `guix lint` will complain about this ;-) Also, the line breaks after home-page and synopsis are not necessary. > + (description "Parallel::ForkManager is intended for use in ^^^ Please use @code{Parallel::ForkManager} here. > +operations that can be done in parallel where the number of > +processes to be forked off should be limited.") > + (license (package-license perl)))) Otherwise LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlh35qwACgkQoqBt8qM6 VPokuggAwzNL6wftKglm4oapj9EyLG9TLIHJVI6IKKsSbpy8aPelT62RzL3FhFHC Nti8aO0aa3xPgE5zgTIjyQSarrxFYwiBuN5Fo/UkTSlDId74SnetMaeNt0XFRW07 bZx90Z8ohWXhsrNT4+pJkmvnPahiH3e8nobWviErrJSBS42/iELRMOXWk3VY8sWo vE40on+CHvp6EMTjq8RnwcOj7+OOJi2ONQmmHOh6agRxD57fG+0N1vzkNZ1Ts/6/ TcG5B1Tv0BWD9MqYvQ8h5T4v/Ht3N4TUXq/BMr6Qq9SyQjV/3pz4ompVhjb39hHL MiIsXsbHwfTzDzYYx9fuiZ1V/E9L8Q== =DyG1 -----END PGP SIGNATURE----- --=-=-=--