From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 02/16] gnu: Add hisat2. Date: Tue, 17 Jan 2017 21:49:20 +0100 Message-ID: <87tw8x76pb.fsf@elephly.net> References: <20170117141141.11694-1-rekado@elephly.net> <20170117141141.11694-3-rekado@elephly.net> <20170117203639.GA17056@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTahA-0007UL-NX for guix-devel@gnu.org; Tue, 17 Jan 2017 15:49:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTah7-0000Be-GY for guix-devel@gnu.org; Tue, 17 Jan 2017 15:49:32 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:21120) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTah7-00009o-80 for guix-devel@gnu.org; Tue, 17 Jan 2017 15:49:29 -0500 In-reply-to: <20170117203639.GA17056@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Tue, Jan 17, 2017 at 03:11:27PM +0100, Ricardo Wurmus wrote: >> * gnu/packages/bioinformatics.scm (hisat2): New variable. > >> + #:make-flags (list "CC=gcc" "CXX=g++" "allall") > > "allall"... We can categorize this alongside -Weverything! ;) > >> + (add-after 'unpack 'make-deterministic >> + (lambda _ >> + (substitute* "Makefile" >> + (("`date`") "0")) > > I'd take the value of SOURCE_DATE_EPOCH from the environment, but it's > not very important. Oh, I’m sorry. I have just pushed based on Marius’s review and didn’t see your message in time. I’ll keep SOURCE_DATE_EPOCH in mind for future cases. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net