all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kei@openmailbox.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: ntfs-3g: Does it build?
Date: Sat, 18 Feb 2017 14:51:21 -0500	[thread overview]
Message-ID: <87tw7rffba.fsf@openmailbox.org> (raw)
In-Reply-To: <20170218183255.7c1368a7@scratchpost.org> (Danny Milosavljevic's message of "Sat, 18 Feb 2017 18:32:55 +0100")


[-- Attachment #1.1: Type: text/plain, Size: 467 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi,
>
> does ntfs-3g build for you using Guix master?
>
> For me, it doesn't - because of a whitespace problem in the patch
> "ntfs-3g-CVE-2017-0358.patch".

I was the one who created that file. Try this patch. It should fix the
whitespace problem. I suspect the issue was that I removed some spaces
before the tabs in the code part of the patch, thinking that they were
insignificant. Clearly I was mistaken.


[-- Attachment #1.2: 0001-gnu-ntfs-3g-Fix-whitespace-in-patch.patch --]
[-- Type: text/plain, Size: 1873 bytes --]

From fff6fb313073aa9121df8ad75c02b896483f433a Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Sat, 18 Feb 2017 14:47:07 -0500
Subject: [PATCH] gnu: ntfs-3g: Fix whitespace in patch.

* gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch: Fix whitespace.
---
 gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch b/gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch
index 6edd676e3..7e5d2a3c9 100644
--- a/gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch
+++ b/gnu/packages/patches/ntfs-3g-CVE-2017-0358.patch
@@ -6,21 +6,21 @@ diff -ur ntfs-3g.old/src/lowntfs-3g.c ntfs-3g/src/lowntfs-3g.c
 --- ntfs-3g.old/src/lowntfs-3g.c	2017-02-09 15:01:04.074331542 -0500
 +++ ntfs-3g/src/lowntfs-3g.c	2017-02-09 15:06:35.757580937 -0500
 @@ -3827,13 +3827,14 @@
-	struct stat st;
-	pid_t pid;
-	const char *cmd = "/sbin/modprobe";
+ 	struct stat st;
+ 	pid_t pid;
+ 	const char *cmd = "/sbin/modprobe";
 +	char *env = (char*)NULL;
-	struct timespec req = { 0, 100000000 };   /* 100 msec */
-	fuse_fstype fstype;
-        
-	if (!stat(cmd, &st) && !geteuid()) {
-		pid = fork();
-		if (!pid) {
+ 	struct timespec req = { 0, 100000000 };   /* 100 msec */
+ 	fuse_fstype fstype;
+         
+ 	if (!stat(cmd, &st) && !geteuid()) {
+ 		pid = fork();
+ 		if (!pid) {
 -			execl(cmd, cmd, "fuse", NULL);
 +			execle(cmd, cmd, "fuse", NULL, &env);
-			_exit(1);
-		} else if (pid != -1)
-			waitpid(pid, NULL, 0);
+ 			_exit(1);
+ 		} else if (pid != -1)
+ 			waitpid(pid, NULL, 0);
 diff -ur ntfs-3g.old/src/ntfs-3g.c ntfs-3g/src/ntfs-3g.c
 --- ntfs-3g.old/src/ntfs-3g.c	2017-02-09 15:01:04.074331542 -0500
 +++ ntfs-3g/src/ntfs-3g.c	2017-02-09 15:06:26.077252571 -0500
-- 
2.11.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-02-18 19:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 17:32 ntfs-3g: Does it build? Danny Milosavljevic
2017-02-18 19:51 ` Kei Kebreau [this message]
2017-02-18 22:13   ` Danny Milosavljevic
2017-02-18 23:11     ` Kei Kebreau
2017-02-18 23:27       ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw7rffba.fsf@openmailbox.org \
    --to=kei@openmailbox.org \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.