From: "Huang\, Ying" <huang_ying_caritas@163.com>
To: guix-devel@gnu.org
Cc: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build
Date: Fri, 24 Feb 2017 20:40:47 +0800 [thread overview]
Message-ID: <87tw7jn4mo.fsf@163.com> (raw)
In-Reply-To: <20170218004427.12392-1-huang_ying_caritas@163.com> (huang ying caritas's message of "Sat, 18 Feb 2017 08:44:26 +0800")
Hi, All,
Can anyone help me to review this patch?
Best Regards,
Huang, Ying
huang_ying_caritas@163.com writes:
> From: Huang Ying <huang.ying.caritas@gmail.com>
>
> * guix/build/union.scm (union-build): Add create-all-directory? keyword
> parameter. To add/remove some files from the directory.
> ---
> guix/build/union.scm | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/guix/build/union.scm b/guix/build/union.scm
> index 6640b5652..4783066be 100644
> --- a/guix/build/union.scm
> +++ b/guix/build/union.scm
> @@ -73,7 +73,8 @@ identical, #f otherwise."
> (loop)))))))))))))
>
> (define* (union-build output inputs
> - #:key (log-port (current-error-port)))
> + #:key (log-port (current-error-port))
> + (create-all-directory? #f))
> "Build in the OUTPUT directory a symlink tree that is the union of all
> the INPUTS."
>
> @@ -104,8 +105,10 @@ the INPUTS."
> (define (union output inputs)
> (match inputs
> ((input)
> - ;; There's only one input, so just make a link.
> - (symlink* input output))
> + ;; There's only one input, so just make a link unless create-all-directory?
> + (if (and create-all-directory? (file-is-directory? input))
> + (union-of-directories output inputs)
> + (symlink* input output)))
> (_
> (call-with-values (lambda () (partition file-is-directory? inputs))
> (match-lambda*
next prev parent reply other threads:[~2017-02-24 12:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 0:44 [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build huang_ying_caritas
2017-02-18 0:44 ` [PATCH 2/2] guix: profiles: create fonts.dir/scale for all fonts directories huang_ying_caritas
2017-02-24 12:40 ` Huang, Ying [this message]
2017-02-24 13:32 ` [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build Andy Wingo
2017-02-25 1:03 ` Huang, Ying
2017-02-24 14:02 ` Danny Milosavljevic
2017-02-24 22:13 ` Mark H Weaver
2017-02-25 12:43 ` Huang, Ying
2017-02-27 9:06 ` Danny Milosavljevic
2017-03-03 1:25 ` Mark H Weaver
2017-02-25 1:05 ` Huang, Ying
2017-02-25 12:30 ` Huang, Ying
2017-02-26 8:23 ` 宋文武
2017-02-27 11:27 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw7jn4mo.fsf@163.com \
--to=huang_ying_caritas@163.com \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.