From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4xaF-0007kp-3P
	for guix-patches@gnu.org; Wed, 18 Oct 2017 19:17:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4xaA-0006po-Tn
	for guix-patches@gnu.org; Wed, 18 Oct 2017 19:17:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40179)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e4xaA-0006pe-Pp
	for guix-patches@gnu.org; Wed, 18 Oct 2017 19:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4xaA-0007Rt-DT
	for guix-patches@gnu.org; Wed, 18 Oct 2017 19:17:02 -0400
Subject: bug#27554: Add dirvish and dependencies
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.27554.D27554.150836861628614.done@debbugs.gnu.org>
References: <8737afvbwd.fsf@dustycloud.org> <877ezq7tmi.fsf@gnu.org>
	<20170702153847.GA18347@jasmine.lan>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20170702153847.GA18347@jasmine.lan>
Date: Thu, 19 Oct 2017 01:16:24 +0200
Message-ID: <87tvyw2gjb.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 27554-done@debbugs.gnu.org


Leo Famulari <leo@famulari.name> writes:

> On Sun, Jul 02, 2017 at 05:20:37PM +0200, Ludovic Courtès wrote:
>> Hi Chris!
>>
>> Christopher Allan Webber <cwebber@dustycloud.org> skribis:
>>
>> > From 60a448f1daf37927155577dabaf1c090f9404bee Mon Sep 17 00:00:00 2001
>> > From: Christopher Allan Webber <cwebber@dustycloud.org>
>> > Date: Sat, 1 Jul 2017 20:45:04 -0500
>> > Subject: [PATCH 1/3] gnu: Add perl-libtime-parsedate.
>> >
>> > * gnu/packages/perl.scm (perl-libtime-parsedate): New variable.
>>
>> [...]
>>
>> > +    (arguments
>> > +     ;; Output when running tests:
>> > +     ;;   t/metdate.t ... skipped: It seems localtime() does not honor
>> > +     ;;   $ENV{TZ} when set in the test script.
>> > +     ;; Seemingly related:
>> > +     ;;   https://stackoverflow.com/questions/19956693/timeparsedate-install-fail
>> > +     ;;   https://rt.cpan.org/Public/Bug/Display.html?id=90367
>> > +     `(#:tests? #f))
>>
>> Perhaps if we add a dependency on tzdata and set TZDIR, as is done for
>> ‘duplicity’ for instance, the tests would run?
>>
>> Anyway this probably shouldn’t block the whole series!
>
> If it only uses them for tests, please use the special tzdata package
> that is just for tests, currently tzdata-2017a.

Thanks for the hint.

I’ve implemented the suggested changes and pushed these patches to
master with commit 0ff4425ce.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net