From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekGuo-0005TS-DM for guix-patches@gnu.org; Fri, 09 Feb 2018 17:13:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekGuk-000637-D3 for guix-patches@gnu.org; Fri, 09 Feb 2018 17:13:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:56180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekGuk-00062x-9m for guix-patches@gnu.org; Fri, 09 Feb 2018 17:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ekGuk-0000Ez-1j for guix-patches@gnu.org; Fri, 09 Feb 2018 17:13:02 -0500 Subject: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180209183635.GB2356@jasmine.lan> Date: Fri, 09 Feb 2018 23:12:03 +0100 In-Reply-To: <20180209183635.GB2356@jasmine.lan> (Leo Famulari's message of "Fri, 9 Feb 2018 13:36:35 -0500") Message-ID: <87tvupx170.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 30400@debbugs.gnu.org Hello, Leo Famulari skribis: > On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote: >> Hi Guix! >>=20 >> I realized today that a new version of crypto++ was out so I set out to >> update it but Clementine failed to compile. There's a patch on master [0] >> that fixes the issue so I was going to apply it when I realized the bit >> of code in question downloads a binary blob to support Spotify. It >> turns out there's a button in the preference menu that allows users to >> download this proprietary blob, and crypto++ appears to be used to check >> it. > > Thanks for pointing this out! I reindented the #:configure-flags and > added some comments to the first patch, and pushed as > af414f34fb6e3609e572880f3b0b3bbcb1b3bfc6 > > My understanding of the FSDG [0] makes me think that we'll need to go > further and, in an origin snippet, remove the code performs the download > of the non-free component. This would mean that `guix build --source > clementine` would return something that follows the FSDG. CC-ing Ludo > for clarification. Correct, removal of non-free code should go in =E2=80=98snippet=E2=80=99 fo= r the reason you gave. Thanks for looking into it, Ludo=E2=80=99.