From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Submitting Patch for r-dyn Description for cran Package Date: Mon, 19 Mar 2018 22:50:23 +0100 Message-ID: <87tvtbd9d6.fsf@elephly.net> References: <20180320001145.Horde.fuQ-DGy6EMUqKib6eerL_wU@swecha.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey6Cw-0000Mt-FT for guix-devel@gnu.org; Mon, 19 Mar 2018 21:36:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey6Cs-0003C9-DM for guix-devel@gnu.org; Mon, 19 Mar 2018 21:36:58 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ey6Cs-0003BI-2Q for guix-devel@gnu.org; Mon, 19 Mar 2018 21:36:54 -0400 In-Reply-To: <20180320001145.Horde.fuQ-DGy6EMUqKib6eerL_wU@swecha.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: sahi@swecha.net Cc: guix-devel@gnu.org Hi, thank you for your contribution! Unfortunately, your email was way too big for me to even open :) Could you please resend it with only the relevant changes? The changes to the =E2=80=9C.po=E2=80=9D files should not be part of the patch. Let=E2=80=99s take a closer look at the R package you=E2=80=99ve added. > +(define-public r-dyn > + (package > + (name "r-dyn") > + (version "0.2-9.6") > + (source > + (origin > + (method url-fetch) > + (uri (cran-uri "dyn" version)) > + (sha256 > + (base32 > + "16fqv9k7yxdgybwzafjkyqm16qpgqz13lcjpi6a1nc8xbzlzh0gb")))) > + (build-system r-build-system) > + (propagated-inputs > + `(("r-zoo" ,r-zoo))) > + (home-page "https://cran.r-project.org/web/packages/dyn") > + (synopsis "Time Series Regression") Please make all worlds except for the first lowercase. > + (description > + "Time series regression. The dyn class interfaces ts, irts(), zoo()= and > +zooreg() time series classes to lm(), glm(), loess(), quantreg::rq(), MA= SS::rlm(), > + MCMCpack::MCMCregress(), quantreg::rq(), randomForest::randomForest() a= nd other > + regression functions allowing those functions to be used with time seri= es including > +specifications that may contain lags, diffs and missing values.") The first sentence is just a sentence fragment. Could you please turn it into a full sentence? Please leave two spaces between sentences. The functions that are mentioned in the description should be wrapped in @code{=E2=80=A6} syntax. Have you tried building this package? (I have not.) Please also add a copyright line to the very top of the file. One more thing: in Guix we follow certain conventions when it comes to commit messages. You can take a look at previous commit messages (with =E2=80=9Cgit log=E2=80=9D) to see examples. In this case the message would look like this: --8<---------------cut here---------------start------------->8--- gnu: Add r-dyn. * gnu/packages/cran.scm (r-dyn): New variable. --8<---------------cut here---------------end--------------->8--- Would you like to send an updated version of your patch? Thanks again for giving this a try! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net