From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fKrXK-0005rl-CJ
	for guix-patches@gnu.org; Mon, 21 May 2018 16:36:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fKrXG-000677-EA
	for guix-patches@gnu.org; Mon, 21 May 2018 16:36:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:35374)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fKrXG-000671-AC
	for guix-patches@gnu.org; Mon, 21 May 2018 16:36:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fKrXG-0000P6-45
	for guix-patches@gnu.org; Mon, 21 May 2018 16:36:02 -0400
Subject: [bug#31531] [PATCH 2/3] gnu: monero: Update to 0.12.0.0.
Resent-Message-ID: <handler.31531.B31531.15269349491530@debbugs.gnu.org>
References: <87bmdbtr7p.fsf@foradis.org>
	<20180519185437.23665-1-theodoros@foradis.org>
	<20180519185437.23665-2-theodoros@foradis.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20180519185437.23665-2-theodoros@foradis.org>
Date: Mon, 21 May 2018 22:35:38 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <87tvr0oig5.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Theodoros Foradis <theodoros@foradis.org>
Cc: 31531@debbugs.gnu.org


Hi Theodoros,

> * gnu/packages/patches/monero-fix-version.patch: New file.
> * gnu/local.mk: Add it.

I think that this patch is better implemented using =E2=80=9Csubstitute*=E2=
=80=9D in a
build phase.

> * gnu/packages/finance.scm: Update to 0.12.0.0.
> [source]: Add patch.
> [inputs]: Add zeromq, cppzmq, libsodium.
> [arguments]: Change build-type to "release".
> Add argument on unit-tests phase.
> Substitute system* with invoke.

The last step (using =E2=80=9Cinvoke=E2=80=9D) is better done in a separate=
 patch.

> -;;; Copyright =C2=A9 2017 Theodoros Foradis <theodoros@foradis.org>
> +;;; Copyright =C2=A9 2017,2018 Theodoros Foradis <theodoros@foradis.org>

Please add a space after the comma.

> -               (zero?
> -                (system* "tests/unit_tests/unit_tests"
> -                         (string-append "--gtest_filter=3D-"
> -                                        excluded-unit-tests))))))
> +               (invoke "tests/unit_tests/unit_tests"
> +                       (string-append "--gtest_filter=3D-"
> +                                      excluded-unit-tests)
> +                       ;; Fix for data dir should be upstream by next up=
date.
> +                       ;; TODO: Delete next command line argument.
> +                       (string-append "--data-dir=3Dtests/data")))))

Wha does the TODO comment mean?

> + function (write_static_version_header hash)
> +   set(VERSIONTAG "${hash}")
> +-  configure_file("src/version.cpp.in" "version.cpp")
> ++  configure_file("${CMAKE_SOURCE_DIR}/src/version.cpp.in" "${CMAKE_BINA=
RY_DIR}/version.cpp")
> + endfunction ()

I=E2=80=99d prefer this to be a short substitute* snippet instead of a patc=
h file.

--
Ricardo