From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkDEB-0000qj-F7 for guix-patches@gnu.org; Mon, 30 Jul 2018 14:49:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkDE6-0002x6-Lz for guix-patches@gnu.org; Mon, 30 Jul 2018 14:49:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkDE6-0002x1-Fs for guix-patches@gnu.org; Mon, 30 Jul 2018 14:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fkDE6-0004A9-4C for guix-patches@gnu.org; Mon, 30 Jul 2018 14:49:02 -0400 Subject: [bug#31999] [PATCH 6/7] gnu: Add libblockdev. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180730133728.30492-1-ambrevar@gmail.com> References: <87bmao3mxk.fsf@fastmail.com> <20180730133728.30492-1-ambrevar@gmail.com> Date: Mon, 30 Jul 2018 20:48:22 +0200 Message-ID: <87tvog1rwp.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Pierre Neidhardt writes: > * gnu/package/disk.scm (libblockdev): New variable. [...] > +(define-public libblockdev > + (package > + (name "libblockdev") > + (version "2.18") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/storaged-project/l= ibblockdev/archive/" > + version "-1.tar.gz")) > + (file-name (string-append name "-" version)) > + (sha256 > + (base32 > + "1q8wh27yngrjvydm9bainda5fgifq8hbgzdsjipkn3nrrhbfy8p9"))= )) Please use the uploaded release tarball instead of the autogenerated git archive: https://github.com/storaged-project/libblockdev/releases/download/2.18-1/li= bblockdev-2.18.tar.gz Then you can remove (file-name ...) since it's already fine. > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("libtool" ,libtool) ...and probably also these inputs. Other than that LGTM, provided `guix lint` is happy! > + ("pkg-config" ,pkg-config) > + ("python" ,python-wrapper) > + ("util-linux" ,util-linux))) > + (inputs > + `(("btrfs-progs" ,btrfs-progs) > + ("cryptsetup" ,cryptsetup) > + ("dosfstools" ,dosfstools) > + ("dmraid" ,dmraid) > + ("eudev" ,eudev) > + ("glib" ,glib) > + ("gobject-introspection" ,gobject-introspection) > + ("kmod" ,kmod) > + ("libbytesize" ,libbytesize) > + ("libyaml" ,libyaml) > + ("lvm2" ,lvm2) > + ("mdadm" ,mdadm) > + ("ndctl" ,ndctl) > + ("nss" ,nss) > + ("parted" ,parted) > + ("volume-key" ,volume-key) > + ;; ("xfsprogs" ,xfsprogs) ; TODO: Package? > + )) > + (home-page "https://github.com/storaged-project/libblockdev") > + (synopsis "Library for manipulating block devices") > + (description > + "libblockdev is a C library supporting GObject introspection for > +manipulation of block devices. It has a plugin-based architecture where= each > +technology (like LVM, Btrfs, MD RAID, Swap...) is implemented in a separ= ate > +plugin, possibly with multiple implementations (e.g. using LVM CLI or th= e new > +LVM D-Bus API).") > + ;; XXX: Copying says LGPL2.1, but the source files with license > + ;; information are GPL2+. > + (license license:gpl2+))) > --=20 > 2.18.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltfXXYACgkQoqBt8qM6 VPqONQf/ZCJnV1jjv1v37fGPWxiutHEkImfvRj6YgKiDYikKHOGMCqCBrB10Ofce +lPGrzqQrUygg3CH0CeW2gVDHkMEWamvK3xoPb9mFziS7V1qT9EUVp6KkyfdAiCi X/L52atHkouSFqMUo5USfKJVRrUqX9etN0VX6TDVtrDd4Km1YVHs+B0erLxjshdE cSpki24EnB+On+iq27nLakIjI9zheyGstBalYyfAMCXldn7PxW7wQQy/obrXF6gm NKxyQdDuRM+G4393vgJqK+j8jrMyJ8yZjupAFBfE+fe5wDQ0tT6qOf4elGtJlF/8 RM4l4MpiWQsJ7xykvcIAcQx2JSHZ6Q== =V/R5 -----END PGP SIGNATURE----- --=-=-=--