From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gv8Fh-0001FT-Su for guix-patches@gnu.org; Sat, 16 Feb 2019 17:16:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gv8Ff-0004Yr-UG for guix-patches@gnu.org; Sat, 16 Feb 2019 17:16:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51300) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gv8Fe-0004YF-7J for guix-patches@gnu.org; Sat, 16 Feb 2019 17:16:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gv8Fd-0007cx-VR for guix-patches@gnu.org; Sat, 16 Feb 2019 17:16:02 -0500 Subject: bug#34246: [PATCH 0/3] Improve the upower-service style. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <877eenqy8f.fsf@cbaines.net> <8736onh15u.fsf@gnu.org> From: Christopher Baines In-reply-to: <8736onh15u.fsf@gnu.org> Date: Sat, 16 Feb 2019 22:15:43 +0000 Message-ID: <87tvh34bxs.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34246-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello! > > Christopher Baines skribis: > >> These patches update the style of the upower-service. Improving and >> documenting the record, and deprecating the >> upower-service procedure. >> >> Directly using record types as default values for service types, along >> with default values for the fields in the record type is generally more >> flexible and configurable than using procedures for service >> configuration. It means that the configuration for the service can be >> changed programatically by generating new configuration based off of the >> original configuration, rather than having to rerun the procedure that >> created the configuration in the first place. >> >> >> Christopher Baines (3): >> services: Improve the upower-configuration record. >> services: Improve the upower-service-type. >> services: desktop: Deprecate the upower-service procedure. > > All three patches LGTM. Thanks for taking the time to do this! :-) Great, I've pushed these patches to master now :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxoi49fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XeDsA//V4gPXv9qfM/mVzni3DgRdWakvJNwqixhn6wpiIVU06AorwTetACh+8Aj CebA35QXeWrWAWSNdhGFYj3kB68ZONW5mKVlLncO/yGf2WF+6kbnHJOB9kt5pUZr xqacL+nkjIRDnwkAhGiT1FWh+iAHjjXmQsKsPTcAe90CuqK0P4CcJ2k+/UiVizrd VEurV/jRNZ8nMlsArdDODAmPLEldi2iLNcHauUSGWTNiMaHFy9ViUmIi8BhTApbk c5+fZOXFX7HXwJLXjx5xTR0W5zZtE9Mv0Gp4/tn4M5S640tHBF9EarZ3d/DSzNU7 sVMIh4pO3SdlQ24IXJCodkE/Uni+vyOlGiYiZvVvKTPLy+Re0YYZg9CB5+tEoucF ZErU95nHrAMP7SfQYrLWAwGfU1x++NMC/zsFJqbP0BxaerRYF2ybnVF+5xWSfGzI F5QHrwSVuqbLBpZ4sqUlBgEPtzW14uI3s955iMr4eLX1lamjmZkL0VxGdhhNiyhR 6IrbaKvhHw8s7LdCLkrG7Af/07WROXz+m8n4Cnnv/m3ShJ7YcQoRNp9OAIHtx6H+ 4EBhPkVHzzWqiL1jgFwkuiaAIWlmpAsFZ0ilt93LV+zyu5ep6L/t502gmzgGq5Dc TxfLgsP/RSOPLuDkjsyFpdwGxuSPHa7a8cl44irZbgqJNwhZL10= =1zYk -----END PGP SIGNATURE----- --=-=-=--