all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34246-done@debbugs.gnu.org
Subject: bug#34246: [PATCH 0/3] Improve the upower-service style.
Date: Sat, 16 Feb 2019 22:15:43 +0000	[thread overview]
Message-ID: <87tvh34bxs.fsf@cbaines.net> (raw)
In-Reply-To: <8736onh15u.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hello!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> These patches update the style of the upower-service. Improving and
>> documenting the <upower-configuration> record, and deprecating the
>> upower-service procedure.
>>
>> Directly using record types as default values for service types, along
>> with default values for the fields in the record type is generally more
>> flexible and configurable than using procedures for service
>> configuration. It means that the configuration for the service can be
>> changed programatically by generating new configuration based off of the
>> original configuration, rather than having to rerun the procedure that
>> created the configuration in the first place.
>>
>>
>> Christopher Baines (3):
>>   services: Improve the upower-configuration record.
>>   services: Improve the upower-service-type.
>>   services: desktop: Deprecate the upower-service procedure.
>
> All three patches LGTM.  Thanks for taking the time to do this!  :-)

Great, I've pushed these patches to master now :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

      reply	other threads:[~2019-02-16 22:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 15:28 [bug#34246] [PATCH 0/3] Improve the upower-service style Christopher Baines
2019-01-29 15:37 ` [bug#34246] [PATCH 1/3] services: Improve the upower-configuration record Christopher Baines
2019-01-29 15:37   ` [bug#34246] [PATCH 2/3] services: Improve the upower-service-type Christopher Baines
2019-01-29 15:37   ` [bug#34246] [PATCH 3/3] services: desktop: Deprecate the upower-service procedure Christopher Baines
2019-02-16 21:30 ` [bug#34246] [PATCH 0/3] Improve the upower-service style Ludovic Courtès
2019-02-16 22:15   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvh34bxs.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=34246-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.