From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gw0DB-0007QS-Fr for guix-patches@gnu.org; Tue, 19 Feb 2019 02:53:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gw0D8-0000dE-S8 for guix-patches@gnu.org; Tue, 19 Feb 2019 02:53:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54514) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gw0D8-0000cj-7f for guix-patches@gnu.org; Tue, 19 Feb 2019 02:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gw0D8-0007uR-3c for guix-patches@gnu.org; Tue, 19 Feb 2019 02:53:02 -0500 Subject: [bug#34515] [PATCH 13/13] gnu: Add Magic-Wormhole. Resent-Message-ID: References: <10c8f51b53835850b458bef15e2a11ab0dc0d70a.1550437064.git.leo@famulari.name> <87sgwlwkcg.fsf@elephly.net> <20190219045526.GF2718@jasmine.lan> From: Ricardo Wurmus In-reply-to: <20190219045526.GF2718@jasmine.lan> Date: Tue, 19 Feb 2019 08:52:08 +0100 Message-ID: <87tvh0usev.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 34515@debbugs.gnu.org Leo Famulari writes: > On Mon, Feb 18, 2019 at 09:51:11AM +0100, Ricardo Wurmus wrote: >> Leo Famulari writes: >> > * gnu/packages/magic-wormhole.scm (magic-wormhole): New variable. >> [=E2=80=A6] >> > + ;; XXX I can't figure out how to build the docs properly. >> > + (add-after 'install 'install-docs >> > + (lambda* (#:key outputs #:allow-other-keys) >> > + (let* ((out (assoc-ref outputs "out")) >> > + (man (string-append out "/share/man/man1"))) >> > + (install-file "docs/wormhole.1" man)) >> > + #t))))) >>=20 >> What does it mean to build them properly? Should anything besides the >> man pages be built? > > In short, it fails like this: > > ------ > make: Entering directory '/tmp/guix-build-magic-wormhole-0.11.2.drv-0/mag= ic-wormhole-0.11.2/docs' > Running Sphinx v1.7.7 > setup.py:20: DeprecationWarning: 'U' mode is deprecated > long_description=3Dopen('README.md', 'rU').read(), > /gnu/store/b7fqhszxl02g6pfm3vw6b3cjz472qrly-python-3.7.0/lib/python3.7/di= stutils/dist.py:274: UserWarning: Unknown distribution option: 'long_descri= ption_content_type' > warnings.warn(msg) > > Configuration error: > There is a programable error in your configuration file: > > Traceback (most recent call last): > File "/gnu/store/q6qyrgr41lqzbray6944l1rs7i6b83kp-python-sphinx-1.7.7/l= ib/python3.7/site-packages/sphinx/config.py", line 161, in __init__ > execfile_(filename, config) > File "/gnu/store/q6qyrgr41lqzbray6944l1rs7i6b83kp-python-sphinx-1.7.7/l= ib/python3.7/site-packages/sphinx/util/pycompat.py", line 150, in execfile_ > exec_(code, _globals) > File "conf.py", line 70, in > version, release =3D _get_versions() > File "conf.py", line 67, in _get_versions > short =3D ".".join(v.split(".")[:2]) > TypeError: a bytes-like object is required, not 'str' > > make: *** [Makefile:20: man] Error 2 > make: Leaving directory '/tmp/guix-build-magic-wormhole-0.11.2.drv-0/magi= c-wormhole-0.11.2/docs' > ------ > > Using the patch under discussion, only a pre-built manual page is > installed. Ah, I see. My guess is that this is due to the use of Python 3.7.0. I wonder if this class of problems disappears with 3.7.1. It=E2=80=99s fine to install the pre-built man pages for now. >> > + (native-inputs >> > + `(("python-mock" ,python-mock) >> > + ;; XXX These are required for the test suite but end up being = referenced >> > + ;; by the built package. >> > + ("magic-wormhole-mailbox-server" ,magic-wormhole-mailbox-serve= r) >> > + ("magic-wormhole-transit-relay" ,magic-wormhole-transit-relay)= )) >>=20 >> Are they not supposed to be referenced by the built package? >> If they are supposed to be used by the built package is it enough to >> have them as inputs and not as propagated inputs? > > In this case they are actually native-inputs, not propagated-inputs. But > they still end up on the PYTHONPATHs in the built package, so they are > referenced. > > I don't believe they are used by the magic-wormhole program except in > client-server way over the network. They shouldn't need to be part of > the closure of magic-wormhole. I think that=E2=80=99s this bug: https://issues.guix.info/issue/25235 Feel free to push your patches. Thanks! --=20 Ricardo