all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 34486@debbugs.gnu.org, Eric Bavier <ericbavier@centurylink.net>
Subject: [bug#34486] [PATCH 0/1] Add '--inherit' to 'guix environment'
Date: Mon, 04 Mar 2019 11:10:49 +0100	[thread overview]
Message-ID: <87tvgjt0eu.fsf@gnu.org> (raw)
In-Reply-To: <87ef82tmxw.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 20 Feb 2019 18:00:11 +0100")

Hi!

Ricardo Wurmus <rekado@elephly.net> skribis:

> Eric Bavier <ericbavier@centurylink.net> writes:
>> I wonder if the word "inherit" here might be too easily confused with
>> the idea of package inheritance.  Could we possibly use an option name
>> that is familiar?  Of-hand I'm thinking of sudo's '-E' and
>> '--preserve-env'.  SLURM itself uses '--export'.  Both of these tools
>> requires passing a list of individual environment variables, but
>> supporting regexp-matching makes sense to me, especially with the SLURM
>> use-case in mind.
>
> I think “export” is a worse name, especially in combination with “guix
> environment”, which sounds like the Guix environment is to be exported.
>
> “preserve” sounds good to me, but it’s also a character longer than
> “inherit” ;)
>
> I’m not a big fan of “inherit” because to me it seems to imply that the
> existing environment is to be inherited fully, while the actual intent
> is to keep only the selected variables.
>
> “keep” or “allow” sound also good to me.

So, what about adding ‘--preserve’ (or ‘--keep’? I slightly prefer
“preserve”) and keeping ‘--inherit’ as a deprecated alias?

We could perhaps add ‘-E’ as well, reclaiming the long-deprecated
‘--exec’, WDYT?

Ludo’.

  reply	other threads:[~2019-03-04 10:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 10:42 [bug#34486] [PATCH 0/1] Add '--inherit' to 'guix environment' Ludovic Courtès
2019-02-15 10:49 ` [bug#34486] [PATCH 1/1] environment: Add '--inherit' Ludovic Courtès
2019-02-15 14:34   ` Thompson, David
2019-02-15 14:54 ` [bug#34486] [PATCH 0/1] Add '--inherit' to 'guix environment' Ricardo Wurmus
2019-02-16  0:05   ` bug#34486: " Ludovic Courtès
2019-02-16  9:12     ` [bug#34486] " Ricardo Wurmus
2019-02-19 14:33       ` Thompson, David
2019-02-16 16:23 ` Eric Bavier
2019-02-18 22:16   ` Ludovic Courtès
2019-02-20 17:00   ` Ricardo Wurmus
2019-03-04 10:10     ` Ludovic Courtès [this message]
2019-03-04 11:01       ` Ricardo Wurmus
2019-03-04 11:14         ` Ludovic Courtès
2019-03-04 11:19           ` Ricardo Wurmus
2019-03-04 14:24             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvgjt0eu.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=34486@debbugs.gnu.org \
    --cc=ericbavier@centurylink.net \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.