From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h83AS-0000oI-9S for guix-patches@gnu.org; Sun, 24 Mar 2019 09:28:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h83AQ-0003gw-9W for guix-patches@gnu.org; Sun, 24 Mar 2019 09:28:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42577) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h83AQ-0003g7-4o for guix-patches@gnu.org; Sun, 24 Mar 2019 09:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h83AP-0007T6-Sr for guix-patches@gnu.org; Sun, 24 Mar 2019 09:28:01 -0400 Subject: [bug#34931] [PATCH 0/5] Add gPodder. Resent-Message-ID: References: <20190321001143.21045-1-pierre.langlois@gmx.com> <87mullv7bx.fsf@gnu.org> From: Pierre Langlois In-reply-to: <87mullv7bx.fsf@gnu.org> Date: Sun, 24 Mar 2019 13:27:01 +0000 Message-ID: <87tvfs8kt6.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34931@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo! Thanks for taking a look! Ludovic Court=C3=A8s writes: > Hello Pierre! > > Pierre Langlois skribis: > >> Here is a patch series to add gPodder [0] and its dependencies. Since >> we have a few packages from the same project I thought we'd add a new >> gpodder.scm file for them. >> >> What do you think? > > I think it=E2=80=99s a good idea. All 5 patches LGTM. > > Unfortunately, python-mygpoclient fails its tests for me: > > --8<---------------cut here---------------start------------->8--- > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > FAIL: test_BadRequest (mygpoclient.http_test.Test_HttpClient) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygp= oclient/http_test.py", line 158, in test_BadRequest > self.assertRaises(BadRequest, client.GET, path) > AssertionError: BadRequest not raised by GET > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > FAIL: test_GET (mygpoclient.http_test.Test_HttpClient) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygp= oclient/http_test.py", line 163, in test_GET > self.assertEquals(client.GET(path), self.RESPONSE) > AssertionError: b'' !=3D b'Test_GET-HTTP-Response-Content' > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > FAIL: test_GET_after_PUT (mygpoclient.http_test.Test_HttpClient) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygp= oclient/http_test.py", line 200, in test_GET_after_PUT > self.assertEquals(client.GET(path), self.RESPONSE + str(i).encode('ut= f-8')) > AssertionError: b'' !=3D b'Test_GET-HTTP-Response-Content0' > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > FAIL: test_NotFound (mygpoclient.http_test.Test_HttpClient) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygp= oclient/http_test.py", line 148, in test_NotFound > self.assertRaises(NotFound, client.GET, path) > AssertionError: NotFound not raised by GET > > [=E2=80=A6] > --8<---------------cut here---------------end--------------->8--- > > Could you take a look? mmmm that's strange, I can't reproduce those failures, was it on master? In the meantime, I noticed there was a makefile with a `test` target which uses the `python-nose` and `python-coverage` packages to run the tests instead. We can try this, I'm not sure I understand how the python build system discovered the tests before. Does the attached patch fix the problem for you? It's a bit of a shot in the dark. Also, I fixed the ChangeLog entry, the patch doesn't include a python2 version of the package since I don't expect packages other than gPodder to depend on this. Thanks, Pierre --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-python-mygpoclient.patch Content-Transfer-Encoding: quoted-printable =46rom 25a1f5a1543274988983cec8bb7e5b9363f382ef Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Wed, 20 Mar 2019 23:55:31 +0000 Subject: [PATCH] gnu: Add python-mygpoclient. * gnu/packages/podcast.scm (python-mygpoclient): New variable. =2D-- gnu/packages/gpodder.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm index 5b872908a5..4eda95e626 100644 =2D-- a/gnu/packages/gpodder.scm +++ b/gnu/packages/gpodder.scm @@ -57,6 +57,36 @@ and track podcasts.") (license license:lgpl2.1+))) +(define-public python-mygpoclient + (package + (name "python-mygpoclient") + (version "1.8") + (source + (origin + (method url-fetch) + (uri (pypi-uri "mygpoclient" version)) + (sha256 + (base32 + "1fi5x6k1mngr0iviw2s4n1f3y2x7pwqy5ivkcrjdprzvwr37f0mh")))) + (build-system python-build-system) + (native-inputs + `(("python-coverage" ,python-coverage) + ("python-minimock" ,python-minimock) + ("python-nose" ,python-nose))) + (arguments + `(#:phases + (modify-phases %standard-phases + (replace 'check + (lambda _ + (invoke "make" "test")))))) + (home-page "https://mygpoclient.readthedocs.io") + (synopsis "Python library for the gPodder web service") + (description "@code{mygpoclient} provides an easy and structured way = to +access the @url{https://gpodder.net} web services. In addition to +subscription list synchronization and storage, the API supports uploading= and +downloading episode status changes.") + (license license:gpl3))) + (define-public python-podcastparser (package (name "python-podcastparser") =2D- 2.21.0 --=-=-=--