From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:59846)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNRTD-0001En-Km
	for guix-patches@gnu.org; Sun, 05 May 2019 20:27:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNRTC-0004zS-KP
	for guix-patches@gnu.org; Sun, 05 May 2019 20:27:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41716)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hNRTC-0004zK-Gw
	for guix-patches@gnu.org; Sun, 05 May 2019 20:27:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNRTC-0007ON-Ci
	for guix-patches@gnu.org; Sun, 05 May 2019 20:27:02 -0400
Subject: bug#35281: [PATCH] gnu: docker: Add a couple go dependencies and
	enable docker-proxy.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.35281.D35281.155710241928401.done@debbugs.gnu.org>
From: T460s laptop <maxim.cournoyer@gmail.com>
References: <87muksnqaq.fsf@gmail.com>
	<20190415082226.03761fcc@scratchpost.org> <877ebuncfy.fsf@gmail.com>
Date: Sun, 05 May 2019 20:26:49 -0400
In-Reply-To: <877ebuncfy.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 15
	Apr 2019 18:14:25 -0400")
Message-ID: <87tve8ctrq.fsf@kwak.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 35281-done@debbugs.gnu.org

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Hi Danny!
>
> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> Hi,
>>
>> On Sun, 14 Apr 2019 19:02:53 -0400
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>>
>>> +         ;; The tests fail with the error:
>>> +         ;; src/github.com/docker/libnetwork/network.go:1057: Warnf format %q
>>> +         ;; has arg n.configOnly of wrong type bool.
>>> +         #:tests? #f))
>>> +      (home-page "https://github.com/docker/libnetwork/")
>>
>> It might make sense to report that bug upstream--they're helpful people.
>>
>> Otherwise LGTM!
>
> Thanks for bringing my attention to that part; I've tried re-enabling
> the tests but it seems to fail because of unmet dependencies now --
> which makes sense since I'm not adding any inputs.  I've removed the
> tests? #f argument and detailed in the top comment that this is simply
> used as a template and doesn't even build.
>
> Thanks for the review!
>
> Maxim

Pushed as 7a31d93a61. Thanks!

Maxim