From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#35585: GRUB does not work with USB keyboards when using
	keyboard-layout
Date: Tue, 07 May 2019 18:11:55 +0200
Message-ID: <87tve62qic.fsf@gnu.org>
References: <20190505173544.f3tjaznsbniyqj5z@pelzflorian.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:43619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO2iF-00025q-4v
	for bug-guix@gnu.org; Tue, 07 May 2019 12:13:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO2iE-00071Z-8k
	for bug-guix@gnu.org; Tue, 07 May 2019 12:13:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45861)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hO2iE-00071V-5W
	for bug-guix@gnu.org; Tue, 07 May 2019 12:13:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hO2iD-0005f9-Tq
	for bug-guix@gnu.org; Tue, 07 May 2019 12:13:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.35585.B35585.155724553321704@debbugs.gnu.org>
In-Reply-To: <20190505173544.f3tjaznsbniyqj5z@pelzflorian.localdomain>
	(pelzflorian@pelzflorian.de's message of "Sun, 5 May 2019 19:35:44
	+0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 35585@debbugs.gnu.org

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:

> From c0c8167cf4f7ddd68567618effc665dd950c2f93 Mon Sep 17 00:00:00 2001
> From: Florian Pelz <pelzflorian@pelzflorian.de>
> Date: Sun, 5 May 2019 17:38:47 +0200
> Subject: [PATCH] bootloader: grub: Support USB keyboards when using a
>  keyboard-layout.
>
> With this USB keyboards are recognized again, the layout does not current=
ly
> get used by GRUB though.
>
> * gnu/booloader/grub.scm (keyboard-layout-config): Add usb_keyboard termi=
nal
> to terminal_input command.

Oh, interesting.  I guess on =E2=80=9CPCs=E2=80=9D the BIOS/UEFI emulates A=
T keyboard
even when the keyboard is really an external USB keyboard, which is why
we don=E2=80=99t see that problem.

> --- a/gnu/bootloader/grub.scm
> +++ b/gnu/bootloader/grub.scm
> @@ -360,7 +360,7 @@ entries corresponding to old generations of the syste=
m."
>                               (keyboard-layout-file layout #:grub grub))))
>            (when keymap
>              (format port "\
> -terminal_input at_keyboard
> +terminal_input at_keyboard usb_keyboard

What do others think?  Danny?

I=E2=80=99d like to make sure this is as harmless as it looks.

Ludo=E2=80=99.