From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: bug#36728: LibreOffice fails to open hyperlinks Date: Thu, 18 Jul 2019 22:17:46 -0700 Message-ID: <87tvbieh6t.fsf@gmail.com> References: <871rymfw3b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:56391) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoLHP-0003KH-EG for bug-guix@gnu.org; Fri, 19 Jul 2019 01:18:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoLHO-0008Si-8v for bug-guix@gnu.org; Fri, 19 Jul 2019 01:18:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hoLHO-0008SM-1v for bug-guix@gnu.org; Fri, 19 Jul 2019 01:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hoLHN-0006pV-RO for bug-guix@gnu.org; Fri, 19 Jul 2019 01:18:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <871rymfw3b.fsf@gmail.com> (Chris Marusich's message of "Thu, 18 Jul 2019 22:10:32 -0700") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: 36728@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Chris Marusich writes: > I have a fix and will post it in a moment. I've verified that the attached patch fixes the issue. It took over 4 hours to build libreoffice on 1 core on my x200 laptop (not including the time it took to build dependencies). I would normally push this directly to master because no packages depend on libreoffice, but the long build time gave me pause. Should I commit this change to master or to somewhere else? =2D-=20 Chris --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-libreoffice-Fix-xdg-open-absolute-paths.patch Content-Transfer-Encoding: quoted-printable From=20fd8875e9c8c7403f979617aa689661e2c33e36ed Mon Sep 17 00:00:00 2001 From: Chris Marusich Date: Mon, 15 Jul 2019 22:42:07 -0700 Subject: [PATCH] gnu: libreoffice: Fix xdg-open absolute paths. Fixes: . * gnu/packages/libreoffice.scm (libreoffice) [inputs]: Add xdg-utils. [arguments][#:phases][prepare-src]: Replace hard-coded absolute paths to xdg-open in the source with the path to xdg-open in the xdg-utils input. =2D-- gnu/packages/libreoffice.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm index 9f5bedd913..026ce92aab 100644 =2D-- a/gnu/packages/libreoffice.scm +++ b/gnu/packages/libreoffice.scm @@ -11,6 +11,7 @@ ;;; Copyright =C2=A9 2017 Rutger Helling ;;; Copyright =C2=A9 2018, 2019 Ricardo Wurmus ;;; Copyright =C2=A9 2018 Jonathan Brielmaier +;;; Copyright =C2=A9 2019 Chris Marusich ;;; ;;; This file is part of GNU Guix. ;;; @@ -53,6 +54,7 @@ #:use-module (gnu packages documentation) #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) #:use-module (gnu packages glib) @@ -1045,6 +1047,7 @@ converting QuarkXPress file format. It supports vers= ions 3.1 to 4.1.") ("unixodbc" ,unixodbc) ("unzip" ,unzip) ("vigra" ,vigra) + ("xdg-utils" ,xdg-utils) ("xmlsec" ,xmlsec-nss) ("zip" ,zip))) (arguments @@ -1077,6 +1080,13 @@ converting QuarkXPress file format. It supports ver= sions 3.1 to 4.1.") (assoc-ref inputs "gpgme") "/include/gpgme++"))) =20 + ;; /usr/bin/xdg-open doesn't exist on Guix System. + (substitute* '("shell/source/unix/exec/shellexec.cxx" + "shell/source/unix/misc/senddoc.sh") + (("/usr/bin/xdg-open") + (string-append (assoc-ref inputs "xdg-utils") + "/bin/xdg-open"))) + #t)) (add-after 'install 'bin-and-desktop-install ;; Create 'soffice' and 'libreoffice' symlinks to the executa= ble =2D-=20 2.20.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAl0xUnsACgkQ3UCaFdgi Rp0HgRAApu5vYlSL0BzsQUSloQv+4KJaVJZsB71EP/qxpFV/bTa44aPiXFIhq1+L GE/GYoFnYZ7B8lMSGBOwbGW70Lm2dmXqYykuqO2X6mSCMsPldLWsSG3ogISpJ7Dt +vHRObQWAXE4QsOVmPW6bbtrUGhDHA123pLBgRLy+N3f6b+woO6BkUQnuuzJeL/t CfqfjFBxKuepXDZ/a8068nhhW9xP4Sdj6ATJIt6/1WOH/fgAk3uviczciNCzcrCf KD8hMavjlDbSw98Kk3HGZOVubxdsg083/Q+sfTNCMu/LufUdbAW8+0LfxjRptG/R GdB5VE0/uooK3mh526JelXhcGz6n4jDDUlABN40N0+xGbWJKNU1iAw0DfmVGZww8 BnkiVVz7yOmlpRa2RpqfnVuwjw06dqPrMPanRcgsVqrOhd/yuSmdFRMTj7gbEjr3 l7L5JJKYcEte3lcLClf4iMRdfytwbNuCy81F6ZAQU4CmIurr1NkN4i41rIM2nyxM G3iyWIEPpqKRSIIJjorcSkT61F216W1tH+ZKcOm9Y8Hng3Gpw9G+usf0vcKmCJOH CYwSwESwkF/AJzeNsUKwWsPdCXPpeOHySinh7GX59RfWrMc16uFTJCuwn7iSDCHv 01YQCNBNVhfDPnv3FHs9O1QtjdSmE3pcmthqWsCmzBJimmK0eE0= =/zkO -----END PGP SIGNATURE----- --==-=-=--