Rust dependency on git

Rust dependency on git

[Ivan Petkov]

Hi Guix,

The latest stable rust (version 1.35.0) appears to require git as a
native-input since the tidy test (which checks for code formatting in the rust
repo) fails because it cannot run `git ls-files`.

I saw a comment in the rust package definition that git changes too frequently
to be kept as an input[1]. Is anyone aware if this is still a problem?
I'd rather avoid having to patch the test suite tools to ignore this test
if it is as simple as adding "git" as a native input.

cc Marius who added this line according to the history.

--Ivan

[1]: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/rust.scm?id=e26d628b0fabf5a0aa7c4164a9558c66c61e02ab#n467

Re: Rust dependency on git

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Hi Ivan,

Ivan Petkov <ivanppetkov@gmail.com> writes:

> Hi Guix,
>
> The latest stable rust (version 1.35.0) appears to require git as a
> native-input since the tidy test (which checks for code formatting in the rust
> repo) fails because it cannot run `git ls-files`.
>
> I saw a comment in the rust package definition that git changes too frequently
> to be kept as an input[1]. Is anyone aware if this is still a problem?
> I'd rather avoid having to patch the test suite tools to ignore this test
> if it is as simple as adding "git" as a native input.

I would prefer to keep Git out of the Rust bootstrap still.  The reason
is that I don't want to rebuild the whole toolchain for every Git update.

Obviously there are other ways to deal with that, so it's not a very
hard opinion.

It seems odd to me that the release tarballs would run 'git ls-files'
anyway.  Do they actually contain a git repository?  Would it work to
simply replace the invokation with 'find'?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Rust dependency on git

[Ivan Petkov]

Hi Marius

> On May 24, 2019, at 3:45 AM, Marius Bakke <mbakke@fastmail.com> wrote:
> 
> It seems odd to me that the release tarballs would run 'git ls-files'
> anyway.  Do they actually contain a git repository?  Would it work to
> simply replace the invokation with 'find’?

Managed to get a chance to dig into this a bit more. The tidy test as a pass
to ensure that no binary files have been accidentally committed into the
repository. It seems like a slight oversight in assuming that the test suite is
run directly on the source repo and not from a source tarball.

It only takes commenting out a single line to unblock things for building in Guix
(I'll be submitting a patch once I can verify it builds locally). I'll also try
to open an issue upstream.

Thanks,
--Ivan

Re: Rust dependency on git

[Chris Marusich]

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

Ivan Petkov <ivanppetkov@gmail.com> writes:

> Hi Marius
>
>> On May 24, 2019, at 3:45 AM, Marius Bakke <mbakke@fastmail.com> wrote:
>> 
>> It seems odd to me that the release tarballs would run 'git ls-files'
>> anyway.  Do they actually contain a git repository?  Would it work to
>> simply replace the invokation with 'find’?
>
> Managed to get a chance to dig into this a bit more. The tidy test as a pass
> to ensure that no binary files have been accidentally committed into the
> repository. It seems like a slight oversight in assuming that the test suite is
> run directly on the source repo and not from a source tarball.
>
> It only takes commenting out a single line to unblock things for building in Guix
> (I'll be submitting a patch once I can verify it builds locally). I'll also try
> to open an issue upstream.

Is this still an issue?

-- 
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Rust dependency on git

[Ivan Petkov]

Hi Chris,

> On Jul 18, 2019, at 10:55 PM, Chris Marusich <cmmarusich@gmail.com> wrote:
> 
> Is this still an issue?

I added a phase to comment out the line which invokes the git based tidy.
For now it’s not an issue, but if things change upstream it may break.

—Ivan