From: Chris Marusich <cmmarusich@gmail.com>
To: Ivan Petkov <ivanppetkov@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Rust dependency on git
Date: Thu, 18 Jul 2019 22:55:32 -0700 [thread overview]
Message-ID: <87tvbi7eln.fsf@gmail.com> (raw)
In-Reply-To: <F62BB77F-E462-4895-9880-DF2269FFA83F@gmail.com> (Ivan Petkov's message of "Sat, 25 May 2019 12:32:30 -0700")
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
Ivan Petkov <ivanppetkov@gmail.com> writes:
> Hi Marius
>
>> On May 24, 2019, at 3:45 AM, Marius Bakke <mbakke@fastmail.com> wrote:
>>
>> It seems odd to me that the release tarballs would run 'git ls-files'
>> anyway. Do they actually contain a git repository? Would it work to
>> simply replace the invokation with 'find’?
>
> Managed to get a chance to dig into this a bit more. The tidy test as a pass
> to ensure that no binary files have been accidentally committed into the
> repository. It seems like a slight oversight in assuming that the test suite is
> run directly on the source repo and not from a source tarball.
>
> It only takes commenting out a single line to unblock things for building in Guix
> (I'll be submitting a patch once I can verify it builds locally). I'll also try
> to open an issue upstream.
Is this still an issue?
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-07-19 5:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 3:22 Rust dependency on git Ivan Petkov
2019-05-24 10:45 ` Marius Bakke
2019-05-25 19:32 ` Ivan Petkov
2019-07-19 5:55 ` Chris Marusich [this message]
2019-07-19 15:10 ` Ivan Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvbi7eln.fsf@gmail.com \
--to=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ivanppetkov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.