From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39549) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inly9-0006Bj-9s for guix-patches@gnu.org; Sat, 04 Jan 2020 11:08:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inly7-0000a2-PB for guix-patches@gnu.org; Sat, 04 Jan 2020 11:08:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37307) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inly6-0000Yj-6t for guix-patches@gnu.org; Sat, 04 Jan 2020 11:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inly6-00060E-1C for guix-patches@gnu.org; Sat, 04 Jan 2020 11:08:02 -0500 Subject: [bug#38809] [PATCH] bootloader: grub: Add resolution override. Resent-Message-ID: From: Jan Nieuwenhuizen References: <87lfquhzmi.fsf@gnu.org> <20200104164512.7589fa36@scratchpost.org> Date: Sat, 04 Jan 2020 17:07:24 +0100 In-Reply-To: <20200104164512.7589fa36@scratchpost.org> (Danny Milosavljevic's message of "Sat, 4 Jan 2020 16:45:12 +0100") Message-ID: <87tv5btdc3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 38809@debbugs.gnu.org Danny Milosavljevic writes: Hi Danny, >> With this patch I finally have a readable GRUB menu. I am not sure >> about the name and semantics of `resolution': Better to use `gfxmode', >> and/or use a list of strings '("1024x768x32" "auto"), ... WDYT? > > Especially with HiDPI, the word "resolution" is ambiguous. > > Also, gfxmode values are not standardized (f.e. u-boot would not know what > to do with them), so using a non-grub-specific key doesn't bring us anyth= ing. That's another good argument; thank you for chiming in! I think we all agree now. I sent an updated patch using `gfxmode' in another mail. > I much prefer lists instead of one string. But grub apparently has "," a= nd > ";" as separators--presumably with the same meaning? Yes, that was also Tobias' wish, so we now have it as a list too. > It also has the special value "keep" as possible first item. > > In view of this complication it's maybe better not to use lists. Hmm, yes that's why I had some doubts too. After Tobias' comment I now chose to use a list, and the example now says (gfxmode '("1024x786x32" "auto")) I hope that people can imagine prepending "keep"? Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com