From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44495) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iq62N-000666-Ny for guix-patches@gnu.org; Fri, 10 Jan 2020 20:58:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iq62M-0008Lp-DM for guix-patches@gnu.org; Fri, 10 Jan 2020 20:58:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49196) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iq62M-0008Kz-90 for guix-patches@gnu.org; Fri, 10 Jan 2020 20:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iq62M-0003Gk-8L for guix-patches@gnu.org; Fri, 10 Jan 2020 20:58:02 -0500 Subject: [bug#38865] [PATCH] add package definition for liquid-dsp-1.3.2 Resent-Message-ID: From: Brett Gilio References: <937849de433222cab5f2da618529ce3aad559546.camel@librehacker.com> <87d0bss243.fsf@gnu.org> Date: Fri, 10 Jan 2020 19:57:29 -0600 In-Reply-To: <87d0bss243.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 09 Jan 2020 23:21:00 +0100") Message-ID: <87tv52n4ae.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Christopher Howard , evan.straw99@gmail.com, 38865@debbugs.gnu.org Ludovic Court=C3=A8s writes: > Hi, > > Christopher Howard skribis: > >> Patch is attached for a new package definition. It passed all guix lint >> checks, except that I received an error from guix lint that it could >> not find the CVE json URL. Package builds and passes all tests on x86- >> 64. > > Oh, the CVE error is weird; could you paste it? > >> From 3c8ccf400dbbf23191b958dfdcef986d1927719c Mon Sep 17 00:00:00 2001 >> From: Christopher Howard >> Date: Wed, 1 Jan 2020 19:58:25 -0900 >> Subject: [PATCH] Adds new package liquid-dsp >> >> --- >> gnu/packages/liquid-dsp.scm | 53 +++++++++++++++++++++++++++++++++++++ > > Could you provide a commit log? (See > .) > > Overall the patch LGTM; minor comments: > >> --- /dev/null >> +++ b/gnu/packages/liquid-dsp.scm > > Packages are usually grouped together in a file that reflect the > category they belong to. Would it make sense to call this file > =E2=80=98sdr.scm=E2=80=99, and it would eventually include other packages= related to > software-defined ratio, or perhaps dsp.scm? > >> +(define-public liquid-dsp >> + (package >> + (name "liquid-dsp") >> + (version "1.3.2") >> + (source >> + (origin (method git-fetch) >> + (uri (git-reference >> + (url (string-append "https://github.com/jgaeddert/li= quid-dsp.git")) > > No need for =E2=80=98string-append=E2=80=99 here. :-) > >> + (synopsis "Signal processing library for software-defined radios wr= itten in C") > > I=E2=80=99d dropped =E2=80=9Cwritten in C=E2=80=9D from the synopsis. > >> + (description >> + "Liquid DSP provides a set of extensible DSP modules that do not > ^ > Please write: =E2=80=9C@dfn{digital signal processing} (DSP) modules=E2= =80=9D, for clarity. > >> +rely on external dependencies or cumbersome frameworks") > > Please add a period at the end. Bonus point if you can expound a bit. > > Could you send an updated patch? > > Thank you! > > Ludo=E2=80=99. > > > > There is also a liquid-dsp patch in #38842 by Evan Straw (cc). --=20 Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]