From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: bug#38320: Cuirass: Allow to use authenticated Git repositories as
 inputs
Date: Thu, 06 Feb 2020 16:16:52 +0100
Message-ID: <87tv43zqxn.fsf@gmail.com>
References: <875zjc8ciz.fsf@lassieur.org> <878so4t6mk.fsf@gmail.com>
 <87r21v9cmi.fsf@gnu.org> <87h829sb73.fsf@gmail.com> <877e34z24m.fsf@gnu.org>
 <87wob3xepy.fsf@gmail.com> <87zhfyvppi.fsf@lassieur.org>
 <8736dp8z2p.fsf@gnu.org> <87tv4667b4.fsf@gmail.com> <87v9omy0es.fsf@gnu.org>
 <87v9oltobu.fsf@gmail.com> <87mu9wlobp.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:54638)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1izitr-000896-1U
 for bug-guix@gnu.org; Thu, 06 Feb 2020 10:17:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1izitq-0007iP-3K
 for bug-guix@gnu.org; Thu, 06 Feb 2020 10:17:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:42322)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1izitp-0007hn-Vo
 for bug-guix@gnu.org; Thu, 06 Feb 2020 10:17:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1izitp-0004e2-Pj
 for bug-guix@gnu.org; Thu, 06 Feb 2020 10:17:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.38320.B38320.158100222017844@debbugs.gnu.org>
In-reply-to: <87mu9wlobp.fsf@gnu.org>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 38320@debbugs.gnu.org, Erik Edrosa <erik.edrosa@gmail.com>, =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>


Hey,

> Perhaps we should not call it at the top level, in case it throws an
> exception or has unwanted side effects?  I=E2=80=99d suggest moving it to
> the procedures where it=E2=80=99s used.  Thoughts?
>
> Apart from that it LGTM, thanks!

Fixed and pushed! Shall we inform users (guix pull news?) that they can
now use ssh authenticated repositories for guix pull + channels if they
have a running ssh-agent?

Mathieu