[bug#40064] Resubmission of patch for Package Description for CRAN Package r-crochet

[bug#40064] Resubmission of patch for Package Description for CRAN Package r-crochet

[Naga Malleswari]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi

I am resubmitting with the new patch file for CRAN Package Description 
r-crochet.

Hope it's the correct way which i was following.


Through put the process,I have doubt in lint.

when i run it , it's showing the error continuously like this with 
different codes.

guix/build/download.scm:313:6: In procedure tls-wrap:
X.509 certificate of 'www.x.org' could not be verified:
   signer-not-found
   invalid

-- 
Regards
NagaMalli


[-- Attachment #2: 0001-gnu-r-crochet-New-variable.patch --]
[-- Type: text/x-patch, Size: 1552 bytes --]

From 873d609cb823422c4658c3070ef727911ff45a85 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Sat, 14 Mar 2020 21:46:26 +0530
Subject: [PATCH]  gnu: r-crochet: New variable.

        * gnu/packages/cran.scm (r-crochet): Added a New Package Description.
---
 gnu/packages/cran.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 406ccc644b..b51862a3ab 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -20794,3 +20794,24 @@ statistics and p-values of the correlation coefficients.")
 scales and utilities, including a spell check function for plot label fields
 and an overall emphasis on typography.")
     (license license:expat)))
+
+(define-public r-crochet
+  (package
+    (name "r-crochet")
+    (version "2.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (cran-uri "crochet" version))
+        (sha256
+          (base32
+            "1cbv79nyycxk6f8ldcsnn2pvgxqlnrj0qs19nhafnq2clxy863k6"))))
+    (build-system r-build-system)
+    (home-page "https://github.com/agrueneberg/crochet")
+    (synopsis "Implementation Helper for '[' and '[<-' of Custom Matrix-Like Types")
+    (description
+      "Functions to help implement the extraction / subsetting /
+indexing function '[' and replacement function '[<-' of custom matrix-like 
+types (based on S3, S4, etc.), modeled as closely to the base matrix class 
+as possible (with tests to prove it).")
+    (license license:expat)))
-- 
2.20.1

[bug#40064] Resubmission of patch for Package Description for CRAN Package r-crochet

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

Hullo Naga,

Naga Malleswari 写道：
> I am resubmitting with the new patch file for CRAN Package 
> Description 
> r-crochet.

Thank you!

> Hope it's the correct way which i was following.

Sending a patch to guix-patches@gnu.org will always create a new 
bug number[0].  In this case, you don't want that to happen.

The way to submit a revised patch is to send it to the previous 
bug number (nnnnn@debbugs.gnu.org, in this case 
40040@debbugs.gnu.org) and clearly mark it as a new revision (V2, 
V3, &c.).

If, like me, you use git send-email, this is easy:

  ~/guix $ git send-email --to=40040@debbugs.gnu.org -v2 -1

I've merged the two duplicate bug numbers for this package.

Kind regards,

T G-R

[0]: 
https://debbugs.gnu.org/cgi/pkgreport.cgi?package=guix-patches;include=subject%3Ar-crochet

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#40064] Resubmission of patch for Package Description for CRAN Package r-crochet

[Naga Malli CH]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Sun, 15 Mar 2020 at 04:11, Tobias Geerinckx-Rice via Guix-patches via <
guix-patches@gnu.org> wrote:

> Hullo Naga,
>
> Naga Malleswari 写道：
> > I am resubmitting with the new patch file for CRAN Package
> > Description
> > r-crochet.
>
> Thank you!



You are Welcome

>
> > Hope it's the correct way which i was following.
>
> Sending a patch to guix-patches@gnu.org will always create a new
> bug number[0].  In this case, you don't want that to happen.
>
> The way to submit a revised patch is to send it to the previous
> bug number (nnnnn@debbugs.gnu.org, in this case
> 40040@debbugs.gnu.org) and clearly mark it as a new revision (V2,
> V3, &c.).
>
> If, like me, you use git send-email, this is easy:
>
>   ~/guix $ git send-email --to=40040@debbugs.gnu.org -v2 -1
>
> I've merged the two duplicate bug numbers for this package.
>
> Sure,I will do that from next time Onwards.


> Kind regards,
>
> T G-R
>
> [0]:
>
> https://debbugs.gnu.org/cgi/pkgreport.cgi?package=guix-patches;include=subject%3Ar-crochet




Can I Now the status of my patch ? Can you please advice me here about the
further process i have to do to reach the contribution?

[-- Attachment #2: Type: text/html, Size: 2432 bytes --]

[bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

Hi,

there's a whitespace error at the bottom of the patch.  When I try to apply it
using "git am" I immediately get a warning message.

Also, the subject you used "gnu: r-crochet: New variable" would mean that
you add a new variable inside r-chochet, which you don't.

It should be: "gnu: Add r-crochet".

and

"* gnu/packages/cran.scm (r-crochet): New variable.".

Please examine some other commit messages in guix master for a template.

I've invoked guix lint and I get:

gnu/packages/cran.scm:20813:6: r-crochet@2.2.0: use @code or similar ornament instead of quotes
/home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet@2.2.0: trailing white space on line 20814
/home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet@2.2.0: trailing white space on line 20815

Could you fix these problems and submit a new version (v3) of the patch
(using git send-email --to=40040@debbugs.gnu.org , for example)?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet

[Naga Malleswari]

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

Hi

Resubmitting v3 of my patch. I really hope i did the changes right.

I am going through documentation and learning the things. For seeking 
clarification, Is there any other way i can communicate with you or the 
community. I have joined IRC channel as well #guix on freenode.

On 17/03/20 3:20 pm, Danny Milosavljevic wrote:
> Hi,
>
> there's a whitespace error at the bottom of the patch.  When I try to apply it
> using "git am" I immediately get a warning message.
>
> Also, the subject you used "gnu: r-crochet: New variable" would mean that
> you add a new variable inside r-chochet, which you don't.
>
> It should be: "gnu: Add r-crochet".
>
> and
>
> "* gnu/packages/cran.scm (r-crochet): New variable.".
>
> Please examine some other commit messages in guix master for a template.

I have done the changes and understood.

> I've invoked guix lint and I get:
>
> gnu/packages/cran.scm:20813:6: r-crochet@2.2.0: use @code or similar ornament instead of quotes
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20814:0: r-crochet@2.2.0: trailing white space on line 20814
> /home/dannym/src/guix-r/guix/gnu/packages/cran.scm:20815:0: r-crochet@2.2.0: trailing white space on line 20815

I am a beginner at this stuff. I am understanding the standards. I have 
invoked lint and found no errors.


> Could you fix these problems and submit a new version (v3) of the patch
> (using git send-email --to=40040@debbugs.gnu.org , for example)?

-- 
Regards
NagaMalli


[-- Attachment #2: 0001-gnu-Add-r-crochet.patch --]
[-- Type: text/x-patch, Size: 1501 bytes --]

From 213ad27a6275d14fe61339ef3adc808f9e8f8b73 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Thu, 19 Mar 2020 13:29:05 +0530
Subject: [PATCH] gnu: Add r-crochet.

* gnu/packages/cran.scm (r-crochet): New variable.
---
 gnu/packages/cran.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 4c18275eaa..90788ba109 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -20794,3 +20794,25 @@ statistics and p-values of the correlation coefficients.")
 scales and utilities, including a spell check function for plot label fields
 and an overall emphasis on typography.")
     (license license:expat)))
+
+(define-public r-crochet
+  (package
+    (name "r-crochet")
+    (version "2.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (cran-uri "crochet" version))
+        (sha256
+          (base32
+            "1cbv79nyycxk6f8ldcsnn2pvgxqlnrj0qs19nhafnq2clxy863k6"))))
+    (build-system r-build-system)
+    (home-page "https://github.com/agrueneberg/crochet")
+    (synopsis "Implementation Helper for Matrix-Like Types")
+    (description
+      "Functions to help implement the extraction / subsetting / indexing
+function @code{[} and replacement function @code{[<-} of custom matrix-like
+types (based on S3, S4, etc.), modeled as closely to the base matrix class
+as possible (with tests to prove it).")
+    (license license:expat)))
+
-- 
2.20.1

[bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Hi Naga,

On Thu, 19 Mar 2020 13:43:30 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

> Resubmitting v3 of my patch. I really hope i did the changes right.

There's still an extra newline at the end of your file.
"git am" still complained.

Also, we are using automated tools to apply these patches.  For that to work
right without manual fiddling, please put eventual mail text below the "---"
and above the "diff" (so it's filtered out by the automated tool).

This time, I had to edit the commit message to remove this conversation
from the git log.

> I am going through documentation and learning the things. For seeking 
> clarification, Is there any other way i can communicate with you or the 
> community. I have joined IRC channel as well #guix on freenode.

For me, E-Mail is fine.  Some other Guix developers are on IRC in #guix
on freenode.

Note: It's better to put the version "v3" also in the subject line.

I've checked the license and I don't think that r-crochet is Free Software
or that the license is expat.  How did you determine the value of the
license field?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet

[Naga Malleswari]

Hi

On 19/03/20 5:08 pm, Danny Milosavljevic wrote:
> Hi Naga,
>
> On Thu, 19 Mar 2020 13:43:30 +0530
> Naga Malleswari <nagamalli@riseup.net> wrote:
>
>> Resubmitting v3 of my patch. I really hope i did the changes right.
> There's still an extra newline at the end of your file.
> "git am" still complained.
Understood I will remove it. It dint showup in lint. I will fix that.
>
> Also, we are using automated tools to apply these patches.  For that to work
> right without manual fiddling, please put eventual mail text below the "---"
> and above the "diff" (so it's filtered out by the automated tool).

Actually i dint get the "Eventual mail text" part. All i have is this in
the patch file

---
 gnu/packages/cran.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff

> This time, I had to edit the commit message to remove this conversation
> from the git log.
>
>> I am going through documentation and learning the things. For seeking 
>> clarification, Is there any other way i can communicate with you or the 
>> community. I have joined IRC channel as well #guix on freenode.
> For me, E-Mail is fine.  Some other Guix developers are on IRC in #guix
> on freenode.
>
> Note: It's better to put the version "v3" also in the subject line.
>
> I've checked the license and I don't think that r-crochet is Free Software
> or that the license is expat.  How did you determine the value of the
> license field?

Yes, you are correct. I have downloaded package description through 
guix import cran -r <package>. This resulted expat licence.

But its showing as MIT in the following link.

https://cran.r-project.org/web/packages/crochet/

The authors github page shows a file licence. Does it mean there is no
proper licensing applied for the package? In that case what should we do.


I have tried to check with previous package contributions in cran.scm
and found mismatch to whats available in website, source page to that of
result from guix import cran -r

r-isoband is showing expat in guix import,   MIT in website(
https://cran.r-project.org/web/packages/isoband/index.html) ,  git page
shows a file https://github.com/wilkelab/isoband

r-hrbrthemes is showing expat in guix import,   MIT in website,  git
page shows a file 


 

-- 
Regards
NagaMalli

[bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 1746 bytes --]

Hi Naga,

On Thu, 19 Mar 2020 23:05:35 +0530
Naga Malleswari <nagamalli@riseup.net> wrote:

> > Also, we are using automated tools to apply these patches.  For that to work
> > right without manual fiddling, please put eventual mail text below the "---"
> > and above the "diff" (so it's filtered out by the automated tool).  
> 
> Actually i dint get the "Eventual mail text" part. All i have is this in
> the patch file

Nevermind, I'll just edit it.

> Yes, you are correct. I have downloaded package description through 
> guix import cran -r <package>. This resulted expat licence.
> 
> But its showing as MIT in the following link.
> 
> https://cran.r-project.org/web/packages/crochet/

Hmm, that looks better.  Weird.

But just judging from https://github.com/agrueneberg/crochet , I wouldn't
have thought that that was under MIT license.  The only mention there
is in the DESCRIPTION file.  Is that enough for Guix?

> The authors github page shows a file licence. Does it mean there is no
> proper licensing applied for the package? In that case what should we do.

Let's wait until someone knowledgeable in CRAN posts.

Could you open an issue on https://github.com/agrueneberg/crochet asking
them to put an Expat license file into the project if that's their intention?

> r-isoband is showing expat in guix import,   MIT in website(
> https://cran.r-project.org/web/packages/isoband/index.html) ,  git page
> shows a file https://github.com/wilkelab/isoband

That has a file LICENSE.md which makes the situation a lot clearer
for that package.

> MIT [...] Expat

MIT is an ambiguous reference, actually it can be either Expat or X11.

See also https://en.wikipedia.org/wiki/MIT_License

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet

[Naga Malleswari]

On 19/03/20 11:23 pm, Danny Milosavljevic wrote:
> Hi Naga,
>
> On Thu, 19 Mar 2020 23:05:35 +0530
> Naga Malleswari <nagamalli@riseup.net> wrote:
>
>>> Also, we are using automated tools to apply these patches.  For that to work
>>> right without manual fiddling, please put eventual mail text below the "---"
>>> and above the "diff" (so it's filtered out by the automated tool).  
>> Actually i dint get the "Eventual mail text" part. All i have is this in
>> the patch file
> Nevermind, I'll just edit it.
>
>> Yes, you are correct. I have downloaded package description through 
>> guix import cran -r <package>. This resulted expat licence.
>>
>> But its showing as MIT in the following link.
>>
>> https://cran.r-project.org/web/packages/crochet/
> Hmm, that looks better.  Weird.
>
> But just judging from https://github.com/agrueneberg/crochet , I wouldn't
> have thought that that was under MIT license.  The only mention there
> is in the DESCRIPTION file.  Is that enough for Guix?
>
>> The authors github page shows a file licence. Does it mean there is no
>> proper licensing applied for the package? In that case what should we do.
> Let's wait until someone knowledgeable in CRAN posts.
>
> Could you open an issue on https://github.com/agrueneberg/crochet asking
> them to put an Expat license file into the project if that's their intention?
I will do that. Meanwhile i will write package definition another
package. Would that be a correct?
>
>> r-isoband is showing expat in guix import,   MIT in website(
>> https://cran.r-project.org/web/packages/isoband/index.html) ,  git page
>> shows a file https://github.com/wilkelab/isoband
> That has a file LICENSE.md which makes the situation a lot clearer
> for that package.


Understood.

But r-hrbrthmes package in cran.scm no license file is found.

https://github.com/hrbrmstr/hrbrthemes

>
>> MIT [...] Expat
> MIT is an ambiguous reference, actually it can be either Expat or X11.
>
> See also https://en.wikipedia.org/wiki/MIT_License

-- 
Regards
NagaMalli

[bug#40040] Resubmission of patch for Package Description for CRAN Package r-crochet

[Naga Malleswari]

Hi

On 19/03/20 11:23 pm, Danny Milosavljevic wrote:

> Yes, you are correct. I have downloaded package description through 
> guix import cran -r <package>. This resulted expat licence.
>
> But its showing as MIT in the following link.
>
> https://cran.r-project.org/web/packages/crochet/
> Hmm, that looks better.  Weird.
>
> But just judging from https://github.com/agrueneberg/crochet , I wouldn't
> have thought that that was under MIT license.  The only mention there
> is in the DESCRIPTION file.  Is that enough for Guix?
>
>> The authors github page shows a file licence. Does it mean there is no
>> proper licensing applied for the package? In that case what should we do.
> Let's wait until someone knowledgeable in CRAN posts.

I have raised the issue and the author said that he followed CRAN
Licensing and included in the description.

https://github.com/agrueneberg/crochet/issues/9

In this case can the patch be approved.

>
> Could you open an issue on https://github.com/agrueneberg/crochet asking
> them to put an Expat license file into the project if that's their intention?
>
>

-- 
Regards
NagaMalli

bug#40040: Resubmission of patch for Package Description for CRAN Package r-crochet

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 116 bytes --]

Hi Naga,

thanks!

I have pushed the patch to guix master as commit
1163dacd4b4d9d274be5e8393072323435e9236a.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]